fix: only save sig cache on last drop #11153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
yash-atreya
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the Arc to only the inner cache in #10282, I inadvertently made all instances of SignaturesIdentifier save the cache on drop, which results in an unnecessary fs write
With #11098 this instance is now present in Cheatcodes so the drop is called on every individual Executor execution (clones Cheatcodes, which clones this struct), e.g. once for every unit tests, fuzz execution etc.
Move the drop impl to an inner struct and wrap everything in Arc