Skip to content

fix(cheatcodes): enforce exit code check for ffiCall #10571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(cheatcodes): enforce exit code check for ffiCall #10571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion crates/cheatcodes/src/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,17 @@ impl Cheatcode for ffiCall {
let Self { commandInput: input } = self;

let output = ffi(state, input)?;
// TODO: check exit code?

if output.exitCode != 0 {
let stderr = String::from_utf8_lossy(&output.stderr);
return Err(fmt_err!(
"FFI command {:?} failed with exit code {}: {}",
input,
output.exitCode,
stderr
));
}

if !output.stderr.is_empty() {
let stderr = String::from_utf8_lossy(&output.stderr);
error!(target: "cheatcodes", ?input, ?stderr, "non-empty stderr");
Expand Down