Update logs.rs #10264
Closed
Update logs.rs #10264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leopardracer
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
mattsse
requested changes
Apr 7, 2025
crates/cast/src/cmd/logs.rs
Outdated
| @@ -269,7 +269,7 @@ mod tests { | |||
|
|
|||
| #[test] | |||
| fn test_build_filter_sig_with_arguments() { | |||
| let addr = Address::from_str(ADDRESS).unwrap(); | |||
| let addr = address!(ADDRESS); | |||
There was a problem hiding this comment.
could we update the function def instead? like instead of defining this as str we can just ADDRESS: Address = address!
mattsse
requested changes
Apr 7, 2025
crates/cast/src/cmd/logs.rs
Outdated
| @@ -269,7 +269,7 @@ mod tests { | |||
|
|
|||
| #[test] | |||
| fn test_build_filter_sig_with_arguments() { | |||
| let addr = Address::from_str(ADDRESS).unwrap(); | |||
| let addr = ADDRESS; | |||
There was a problem hiding this comment.
now these tmp vars are redundant and we can get rid of them
mattsse
previously approved these changes
Apr 7, 2025
mattsse
reviewed
Apr 7, 2025
crates/cast/src/cmd/logs.rs
Outdated
| @@ -217,7 +218,7 @@ mod tests { | |||
| fn test_build_filter_basic() { | |||
| let from_block = Some(BlockNumberOrTag::from(1337)); | |||
| let to_block = Some(BlockNumberOrTag::Latest); | |||
| let address = Address::from_str(ADDRESS).ok(); | |||
| let address = Address::from_str(ADDRESS.to_string()).ok(); | |||
|
This has no title, description, and is not a change of value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.