-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preprocessor to skip recompiling tests on non-interface source file changes #252
base: main
Are you sure you want to change the base?
Conversation
1c02f7f
to
325a627
Compare
325a627
to
0f78197
Compare
crates/compilers/src/preprocessor.rs
Outdated
|| visibility == Visibility::Public | ||
}) | ||
} | ||
solar_parse::ast::FunctionKind::Constructor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please import ast
instead of using crate name::
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, done, will clean more imports when moving to use solar HIR 594c09b
} | ||
} | ||
|
||
impl Visitor for BytecodeDependencyCollector<'_> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should use solar HIR, requires patching to latest git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DaniPopes I am having some difficulties figuring out how to use HIR API (trying smth like below), could you please shed some light? thank you!
sess.enter_parallel(|| -> solar_parse::interface::Result {
let sources = sources.into_iter().map(|(path, _)| path);
let mut parsing_context = ParsingContext::new(&sess);
parsing_context.load_files(sources)?;
parsing_context.parse_and_resolve()?;
/// Do something with parsed sources, access HIR
Ok(())
});
b4c0746
to
7d0edb8
Compare
b5ebece
to
4025e5a
Compare
be6c378
to
d37cafb
Compare
supersedes #198
Implements preprocessor allowing us to skip recompiling tests on non-interface source file changes. Still testing, but looks like it's working correctly, decreasing single-change build times from ~1 minute to 5s in some cases.
TODOs