Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:Retrieval of tokenizer_kwargs in data handler tokenize_and_apply_input_masking #465

Merged
merged 1 commit into from
Feb 12, 2025
Merged

fix:Retrieval of tokenizer_kwargs in data handler tokenize_and_apply_input_masking #465

merged 1 commit into from
Feb 12, 2025

Conversation

Abhishek-TAMU
Copy link
Collaborator

@Abhishek-TAMU Abhishek-TAMU commented Feb 11, 2025 •
edited
Loading

Description of the change

Handler tokenize_and_apply_input_masking here, couldn't read tokenizer_kwargs due to incorrect retrieval from tokenizer_kwargs passed to this handler when applying map here.

Related issue number

Issue: #464

How to verify the PR

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added.
  • I have ensured all unit tests pass

@github-actions GitHub Actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Feb 11, 2025
@github-actions GitHub Actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@Abhishek-TAMU Abhishek-TAMU mentioned this pull request Feb 11, 2025
Open
@dushyantbehl
Copy link
Contributor

LGTM! Thanks @Abhishek-TAMU

@willmj can you please review as well and we can move to make this available.

willmj
willmj approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@willmj willmj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Abhishek

@Abhishek-TAMU Abhishek-TAMU merged commit a89a4a3 into foundation-model-stack:main Feb 12, 2025
11 checks passed
@Abhishek-TAMU Abhishek-TAMU deleted the fix_handler_kwargs branch February 12, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmj willmj willmj approved these changes

@anhuong anhuong Awaiting requested review from anhuong anhuong is a code owner

@Ssukriti Ssukriti Awaiting requested review from Ssukriti Ssukriti is a code owner

@aluu317 aluu317 Awaiting requested review from aluu317 aluu317 is a code owner

@fabianlim fabianlim Awaiting requested review from fabianlim fabianlim is a code owner

@kmehant kmehant Awaiting requested review from kmehant kmehant is a code owner

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abhishek-TAMU @dushyantbehl @willmj