-
Notifications
You must be signed in to change notification settings - Fork 24
Adds sample yaml file for pod creation #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Flavia Beo <[email protected]>
Signed-off-by: Flavia Beo <[email protected]>
kind: Pod | ||
apiVersion: v1 | ||
metadata: | ||
name: <user>-dev-e2e-1x-aiu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add comment saying: # this is a sample pod name.
requests: | ||
ibm.com/aiu_pf: '1' | ||
terminationMessagePath: /dev/termination-log | ||
name: <user>-dev-e2e-1x-aiu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment: # Sample container name. Substitute with your own name.
- name: HF_HUB_OFFLINE | ||
value: '1' | ||
- name: HF_HOME | ||
value: /home/senuser/models/huggingface_cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this comment. # This can be canned to your local home path environment.
Since this will be exposed externally, we should say that we are just providing a sample yaml. User can adjust the fields based on their AIU image and cluster environment.
- name: dev-shm | ||
mountPath: /dev/shm | ||
terminationMessagePolicy: File | ||
image: &pod_image icr.io/ibmaiu_internal/x86_64/dd2/e2e_stable:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment # AIU software image
Signed-off-by: Flavia Beo <[email protected]>
- name: DT_DEEPRT_VERBOSE | ||
value: '-1' | ||
- name: POD_IMAGE | ||
value: *pod_image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve never seen the POD_IMAGE
and FMS_CHECKOUT
env vars before, where does it get used in the stack? Thanks
mountPath: /dev/shm | ||
terminationMessagePolicy: File | ||
# AIU software image | ||
image: &pod_image icr.io/ibmaiu_internal/x86_64/dd2/e2e_stable:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an internal image, can we remove this path please?
workingDir: /home/senuser | ||
args: | ||
- | | ||
source ~/.bashrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be in line with the README we might not need all these args
The README docs mention a
pod.yaml
file that currently does not exist in the repo. Adding a sample YAML file for completeness.cc: @kaoutar55