Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "/MP" compiler flag for MSVC to speed up build process. #311

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add "/MP" compiler flag for MSVC to speed up build process. #311

wants to merge 2 commits into from

Conversation

CreativeLau
Copy link
Contributor

No description provided.

HuguesDelorme
HuguesDelorme requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@HuguesDelorme HuguesDelorme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the changes should just check if cmake generator is VisualStudio. If yes then straight add /MP to Mayo_CompileOptions cmake variable

@CreativeLau
Copy link
Contributor Author

Definitely, it should be modified as your recommendation. I have changed the pull request.

HuguesDelorme
HuguesDelorme requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@HuguesDelorme HuguesDelorme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition of /MP should happen only when cmake generator is VisualStudio(ie cmake creates VisualStudio projects)
Otherwise this option will break build of other make systems(eg ninja, nmake, ...)

@CreativeLau
Copy link
Contributor Author

Yes, the /MP will be appended only if the compiler is MSVC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuguesDelorme HuguesDelorme HuguesDelorme requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CreativeLau @HuguesDelorme