Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(obligation_apis): Make GET obligation classifications and types unauthorized #100

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(obligation_apis): Make GET obligation classifications and types unauthorized #100

wants to merge 1 commit into from

Conversation

deo002
Copy link
Collaborator

@deo002 deo002 commented Feb 19, 2025

Changes

  • The GET obligation types and obligation classifications apis should not be authorized. Only the update, create and delete ones should. These values will be needed in forms for obligation updation/creation.

Submitter Checklist

  • Includes tests (if there is a feature changed/added)
  • Includes docs ( if changes are user facing)
  • I have tested my changes locally.

@deo002 deo002 requested a review from GMishx February 19, 2025 08:59
Kaushl2208
Kaushl2208 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@Kaushl2208 Kaushl2208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Needs test :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kaushl2208 Kaushl2208 Kaushl2208 approved these changes

@GMishx GMishx Awaiting requested review from GMishx

Assignees
No one assigned
Labels
needs code review needs test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deo002 @Kaushl2208 @GMishx