-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add NIC specific part of MAC address as suffix to SSID #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This feature will make it easier to tell the WiFis of PSLab devices apart. Might be useful when running a workshop.
Reviewer's Guide by SourceryThis pull request introduces a feature that appends a suffix, derived from the device's MAC address, to the SSID. This change helps distinguish between multiple PSLab devices' WiFis, particularly in workshop settings. The implementation involves a new Sequence diagram for WiFi softAP setup with MAC address suffixsequenceDiagram
participant ESP01Firmware
participant WiFi
ESP01Firmware->>ESP01Firmware: setup()
ESP01Firmware->>ESP01Firmware: getSuffix()
ESP01Firmware-->>WiFi: macAddress()
WiFi-->>ESP01Firmware: MAC Address
ESP01Firmware->>ESP01Firmware: Remove vendor ID and colons from MAC Address
ESP01Firmware-->>ESP01Firmware: Suffix
ESP01Firmware->>WiFi: softAP(ssid + suffix, password)
WiFi-->>ESP01Firmware: WiFi AP started
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @marcnause - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a compile-time flag to enable/disable this feature.
- Consider adding a unit test for the getSuffix function.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcnause Maybe we could also update the docs in scope of this PR ? Precisely here:
pslab-esp01-firmware/docs/esptool.md
Line 91 in c2a796f
Now pull the ESP-01's GPIO_0 pin high and reset it. If the new firmware was flashed successfully, it will start broadcasting an SSID called "PSLab". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't adopted a style for this project yet, but the following is my preference. It's what I'm using in pslab-firmware.
Co-authored-by: Alexander Bessman <[email protected]>
Co-authored-by: Alexander Bessman <[email protected]>
The last six bytes of the device specific MAC address of the ESP01 will be used as a suffix for the SSID.
This feature will make it easier to tell the WiFis of PSLab devices apart. Might be useful when running a workshop.
Summary by Sourcery
Modify WiFi SSID generation to include the device-specific part of the MAC address as a unique suffix
New Features:
Enhancements: