Skip to content

feat: add NIC specific part of MAC address as suffix to SSID #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 11, 2025

Conversation

marcnause
Copy link
Contributor

@marcnause marcnause commented Apr 11, 2025

The last six bytes of the device specific MAC address of the ESP01 will be used as a suffix for the SSID.

This feature will make it easier to tell the WiFis of PSLab devices apart. Might be useful when running a workshop.

image

Summary by Sourcery

Modify WiFi SSID generation to include the device-specific part of the MAC address as a unique suffix

New Features:

  • Add a unique suffix to the WiFi SSID based on the last six bytes of the device's MAC address

Enhancements:

  • Implement a method to extract and format the device-specific MAC address for SSID differentiation

This feature will make it easier to tell the WiFis of PSLab devices apart. Might be useful when running a workshop.
Copy link

sourcery-ai bot commented Apr 11, 2025

Reviewer's Guide by Sourcery

This pull request introduces a feature that appends a suffix, derived from the device's MAC address, to the SSID. This change helps distinguish between multiple PSLab devices' WiFis, particularly in workshop settings. The implementation involves a new getSuffix() function to generate the suffix and modification of the WiFi.softAP() call to include it.

Sequence diagram for WiFi softAP setup with MAC address suffix

sequenceDiagram
  participant ESP01Firmware
  participant WiFi

  ESP01Firmware->>ESP01Firmware: setup()
  ESP01Firmware->>ESP01Firmware: getSuffix()
  ESP01Firmware-->>WiFi: macAddress()
  WiFi-->>ESP01Firmware: MAC Address
  ESP01Firmware->>ESP01Firmware: Remove vendor ID and colons from MAC Address
  ESP01Firmware-->>ESP01Firmware: Suffix
  ESP01Firmware->>WiFi: softAP(ssid + suffix, password)
  WiFi-->>ESP01Firmware: WiFi AP started
Loading

File-Level Changes

Change Details Files
Implemented a function to generate a suffix for the SSID based on the device's MAC address and appended it to the SSID.
  • Added a getSuffix() function to extract the last six bytes of the MAC address, remove colons, and prepend an underscore.
  • Modified the WiFi.softAP() call to include the generated suffix in the SSID.
src/ESP01Firmware/ESP01Firmware.ino

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marcnause - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a compile-time flag to enable/disable this feature.
  • Consider adding a unit test for the getSuffix function.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@AsCress AsCress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcnause Maybe we could also update the docs in scope of this PR ? Precisely here:

Now pull the ESP-01's GPIO_0 pin high and reset it. If the new firmware was flashed successfully, it will start broadcasting an SSID called "PSLab".

Copy link
Contributor

@bessman bessman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't adopted a style for this project yet, but the following is my preference. It's what I'm using in pslab-firmware.

@marcnause
Copy link
Contributor Author

@AsCress @bessman Thank you for your suggestions. I have added them.

@marcnause marcnause merged commit 8792daf into fossasia:main Apr 11, 2025
2 checks passed
@marcnause marcnause deleted the extendSSID branch April 11, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants