Skip to content

chore: update screenshots on every push #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

AsCress
Copy link
Collaborator

@AsCress AsCress commented Apr 10, 2025

Update screenshots on every push as we do for badgemagic-app, instead of capturing them on tagged releases.

Screenshots / Recordings

N/A

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Update GitHub Actions workflow to capture and update screenshots on every push instead of only during tagged releases

CI:

  • Modify screenshot capture workflow to run on every push, adding automatic screenshot updates to the fastlane branch

Chores:

  • Reconfigure release workflow to remove screenshot capture from release process

@AsCress AsCress added the Chore Changes to things that do not go into production label Apr 10, 2025
@AsCress AsCress requested a review from adityastic April 10, 2025 10:10
@AsCress AsCress self-assigned this Apr 10, 2025
Copy link

sourcery-ai bot commented Apr 10, 2025

Reviewer's Guide by Sourcery

The pull request modifies the screenshot capture workflow to run on every push event, instead of only on tagged releases. This change ensures that the screenshots are always up-to-date.

Sequence diagram for updating Fastlane metadata

sequenceDiagram
    actor GitHub Actions Bot
    participant Git

    GitHub Actions Bot->>Git: Configures user name and email
    GitHub Actions Bot->>Git: Checks out temporary branch
    Git->>Git: Creates orphan branch 'temporary'
    GitHub Actions Bot->>Git: Adds all files
    GitHub Actions Bot->>Git: Commits changes with message
    GitHub Actions Bot->>Git: Deletes branch 'fastlane-android'
    GitHub Actions Bot->>Git: Renames branch 'temporary' to 'fastlane-android'
    GitHub Actions Bot->>Git: Force pushes 'fastlane-android' to origin
Loading

File-Level Changes

Change Details Files
Update the screenshot capture workflow to run on every push event, instead of only on tagged releases.
  • Modified the screenshot-android action to update Fastlane metadata on push events.
  • Configured Git to use the github-actions[bot] user for committing changes.
  • Force-pushed changes to the fastlane-android branch.
  • Modified the release workflow to clone the fastlane-android branch.
  • Removed the Android Screenshot Workflow from the release workflow.
.github/actions/screenshot-android/action.yml
.github/workflows/release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AsCress - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a step to verify the push to the fastlane-android branch was successful.
  • The workflow now updates screenshots on every push; consider the implications for storage and bandwidth usage.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

@AsCress AsCress requested a review from bessman April 11, 2025 12:44
Copy link
Contributor

@bessman bessman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AsCress AsCress merged commit 4c0bac1 into fossasia:development Apr 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Changes to things that do not go into production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants