-
Notifications
You must be signed in to change notification settings - Fork 818
chore: update screenshots on every push #2667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThe pull request modifies the screenshot capture workflow to run on every push event, instead of only on tagged releases. This change ensures that the screenshots are always up-to-date. Sequence diagram for updating Fastlane metadatasequenceDiagram
actor GitHub Actions Bot
participant Git
GitHub Actions Bot->>Git: Configures user name and email
GitHub Actions Bot->>Git: Checks out temporary branch
Git->>Git: Creates orphan branch 'temporary'
GitHub Actions Bot->>Git: Adds all files
GitHub Actions Bot->>Git: Commits changes with message
GitHub Actions Bot->>Git: Deletes branch 'fastlane-android'
GitHub Actions Bot->>Git: Renames branch 'temporary' to 'fastlane-android'
GitHub Actions Bot->>Git: Force pushes 'fastlane-android' to origin
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AsCress - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a step to verify the push to the
fastlane-android
branch was successful. - The workflow now updates screenshots on every push; consider the implications for storage and bandwidth usage.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/14377881783/artifacts/2918418536 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Update screenshots on every push as we do for badgemagic-app, instead of capturing them on tagged releases.
Screenshots / Recordings
N/A
Checklist:
strings.xml
,dimens.xml
andcolors.xml
without hard coding any value.strings.xml
,dimens.xml
orcolors.xml
.Summary by Sourcery
Update GitHub Actions workflow to capture and update screenshots on every push instead of only during tagged releases
CI:
Chores: