refactor: added helper method

[rahul31124]

Added Helper Method

Fixes #2664 and Fixes #2665

Changes

Added Helper Method

Screenshots / Recordings

N/A

Checklist:

• No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
• No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
• Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
• No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Refactor degree input handling in RoboticArmActivity by introducing a helper method to fix issues #2664 and #2665, improving code maintainability and reducing redundancy.

Bug Fixes:

• Fix issues Refactor: Consolidate Repeated Logic into Helper Method #2664 and Refactor Degree Parsing and Updating Logic into a Helper Method #2665 related to degree input handling in the RoboticArmActivity.

Enhancements:

• Refactor degree input handling by introducing a helper method 'processDegreeInput' to streamline and centralize the logic.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a helper method, processDegreeInput, to handle the common logic for processing degree inputs from the text fields associated with each servo. This change reduces code duplication and improves maintainability by centralizing the input validation and processing steps.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Refactored repetitive degree input processing logic into a single helper method.	Created a new method processDegreeInput to handle degree input processing. Replaced duplicated code blocks in onEditorAction for each servo with calls to the new helper method.	app/src/main/java/io/pslab/activity/RoboticArmActivity.java

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#2664	Encapsulate the repeated logic of retrieving, trimming, checking if empty, and conditionally setting the 'degree' value for text fields into a private helper method.	✅
#2664	Replace the repeated logic in the codebase with calls to the new helper method.	✅
#2664	Ensure no functionality is broken by the refactor.	✅

Possibly linked issues

• Refactor: Consolidate Repeated Logic into Helper Method #2664: The PR implements the helper method suggested in the issue to reduce redundant code for parsing and updating degree values.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @rahul31124 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider renaming degreeStr to degreeText for consistency with the parameter name.
• The helper method could be static since it doesn't access any instance members.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (bug_risk): Review global state usage in processDegreeInput.

The method modifies a shared global variable 'degree' (and 'editEnter'). Ensure that this side effect is intentional and safe given the UI's handling, particularly if multiple text inputs could be manipulated concurrently.

Suggested implementation:

    private int processDegreeInput(EditText degreeText, SeekArc seekArc, int currentDegree) {
        int previousDegree = currentDegree;
        String degreeStr = degreeText.getText().toString().trim();

        if (degreeStr.isEmpty()) {
            int newDegree = (currentDegree == 0) ? (int) (seekArc.getProgress() * 3.6) : previousDegree;
            return newDegree;
        } else {
            try {
                int newDegree = Integer.parseInt(degreeStr);
                return newDegree;
            } catch (NumberFormatException e) {
                degreeText.setText(getResources().getString(R.string.zero));
                seekArc.setProgress(0);
                toastInvalidValueMessage();
                return 0;
            }
        }
    }

                    degree = processDegreeInput(degreeText4, seekArc4, degree);

Note:

1. If there is similar global state usage for "editEnter" or other shared variables, refactor them likewise (e.g., pass them as method parameters or use local variables) so that state changes are explicit.
2. Verify that all calling code is updated to use the returned degree value appropriately.
3. Adjust any tests or related UI handling to reflect these changes.

[github-actions]

Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/14240361292/artifacts/2874233274

[AsCress]

LGTM @rahul31124 ! Thank you very much !