-
Notifications
You must be signed in to change notification settings - Fork 818
docs: Ctrehan1/2659 #2661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Ctrehan1/2659 #2661
Conversation
Reviewer's Guide by SourceryThis pull request adds new strings to the application, mainly focusing on documentation and sensor readings. It also includes translations for these new strings in Arabic, Polish, Russian, and Sinhala. The changes involve adding new string resources to the respective No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ChehakTrehan - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like you're adding translations for new features, which is great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Hii @huitk I made changes and raised the PR . Please review it |
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/14223048213/artifacts/2868369001 |
Updated changes
Summary by Sourcery
Update localization strings for multiple languages, adding new navigation and sensor-related translations
Enhancements:
Documentation: