Skip to content

docs: Ctrehan1/2659 #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ChehakTrehan
Copy link
Contributor

@ChehakTrehan ChehakTrehan commented Apr 2, 2025

Updated changes

Summary by Sourcery

Update localization strings for multiple languages, adding new navigation and sensor-related translations

Enhancements:

  • Standardize lux unit representation across language files

Documentation:

  • Add new localized strings for documentation navigation, sensor measurements, and color terms across Arabic, Polish, Russian, and Sinhala languages

Copy link

sourcery-ai bot commented Apr 2, 2025

Reviewer's Guide by Sourcery

This pull request adds new strings to the application, mainly focusing on documentation and sensor readings. It also includes translations for these new strings in Arabic, Polish, Russian, and Sinhala. The changes involve adding new string resources to the respective strings.xml files for each language.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added translations for new strings related to documentation, sensor readings (light, proximity, gesture, air quality), and plot descriptions.
  • Added translation for "nav_documentation".
  • Added translations for sensor readings: red, green, blue, clear, gesture, eCO2, eTVOC, proximity, lux_unit, light_lux.
  • Added translations for plot descriptions: plot_lux, plot_proximity.
app/src/main/res/values-ar/strings.xml
app/src/main/res/values-pl/strings.xml
app/src/main/res/values-ru/strings.xml
app/src/main/res/values-si/string.xml
app/src/main/res/values/strings.xml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ChehakTrehan - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It looks like you're adding translations for new features, which is great!
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ChehakTrehan
Copy link
Contributor Author

Hii @huitk I made changes and raised the PR . Please review it
Thanks
Chehak

Copy link

github-actions bot commented Apr 2, 2025

@marcnause marcnause added the Status: Review Required Requested reviews from peers and maintainers label Apr 2, 2025
@marcnause marcnause self-requested a review April 2, 2025 21:00
@marcnause
Copy link
Contributor

Duplicate of #2660.

I will close this PR in favor of #2660.

@marcnause marcnause closed this Apr 2, 2025
@marcnause marcnause added Duplicate Issue or PR already exists and removed Status: Review Required Requested reviews from peers and maintainers labels Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate Issue or PR already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants