-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update device_filter.xml #2640
base: development
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request enhances the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @td15 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider grouping the Raspberry Pi Pico entries with a single comment block.
- It might be helpful to add a comment indicating which devices use the CDC driver.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/13705592733/artifacts/2705819809 |
@td15 Thank you for your work ! Could you please check the failing CI (Semantic Validation)? |
Fixes #
Changes
Screenshots / Recordings
Checklist:
strings.xml
,dimens.xml
andcolors.xml
without hard coding any value.strings.xml
,dimens.xml
orcolors.xml
.Summary by Sourcery
Updates the device_filter.xml file to provide more descriptive comments for each USB device entry, improving readability and maintainability. Also, the comments are reworded to be more consistent.