fix: pending ticket redirected to payment page. #2356

captain82 · 2019-09-20T17:45:26Z

…d to the payment page

Fixes #2077

Changes: Snackbar is now showing for orders that are expired and canceled and not generating tickets for them. For pending payments user is now redirected to the payment page of their respective payment method.

…edirected to payment page

nikit19

I see a lot of unrelated indentation changes. Please fix it and make sure the build passes

liveHarshit · 2019-09-20T20:57:44Z

Also, follow the guidelines: https://blog.fossasia.org/open-source-developer-guide-and-best-practices-at-fossasia/

Open Source Developer Guide and Best Practices at FOSSASIA | blog.fossasia.org
I would request you to please guide me as to how can I collaborate with you and also how can I contribute effectively to the organization. At times I might get

captain82 · 2019-09-24T04:16:14Z

I see a lot of unrelated indentation changes. Please fix it and make sure the build passes

ok @nikit19

captain82 · 2019-09-24T04:17:06Z

Also, follow the guidelines: https://blog.fossasia.org/open-source-developer-guide-and-best-practices-at-fossasia/

**Open Source Developer Guide and Best Practices at FOSSASIA | blog.fossasia.org**I would request you to please guide me as to how can I collaborate with you and also how can I contribute effectively to the organization. At times I might get

@liveHarshit Why do Travis build keeps getting failed.

Open Source Developer Guide and Best Practices at FOSSASIA | blog.fossasia.org
I would request you to please guide me as to how can I collaborate with you and also how can I contribute effectively to the organization. At times I might get

liveHarshit · 2019-09-24T06:16:42Z

@liveHarshit Why do Travis build keeps getting failed.

Check the logs: https://travis-ci.org/fossasia/open-event-attendee-android/builds/587602382?utm_source=github_status&utm_medium=notification and comment: #2346 (comment)

…-attendee-android into development

captain82 · 2019-09-26T18:45:35Z

@liveHarshit Semantic pull request is not passing.help needed.

iamareebjamal · 2019-09-26T20:07:06Z

You still haven't written the title in the same format as required. You are a programmer. You should know this.

if a > b:
    print('Hello')

ifa > b:
    print('Hello')

Are both of these statement equivalent?
How is the parser going to separate between the two

captain82 · 2019-09-27T03:15:12Z

You still haven't written the title in the same format as required. You are a programmer. You should know this.
if a > b:
    print('Hello')
ifa > b:
    print('Hello')
Are both of these statement equivalent?
How is the parser going to separate between the two

space between if and a.

All checks passed . Thank you @iamareebjamal

liveHarshit

Please provide GIF.

iamareebjamal · 2019-09-27T07:58:22Z

app/src/main/java/org/fossasia/openevent/general/order/OrdersViewHolder.kt

@@ -29,7 +29,7 @@ class OrdersViewHolder(private val binding: ItemCardOrderBinding) : RecyclerView
        }

        itemView.setOnClickListener {
-            listener?.onClick(event.id, order.identifier ?: "", order.id)
+            listener?.onClick(event.id, order.identifier ?: "", order.id, event, order)


Please change the parameters to a class

@iamareebjamal this OrderClickListener is used in more 3 fragments. If I change here I have to do that at all places. Should I do it?

That's the point of refactoring

@iamareebjamal ok.all the 5 parameters should be replaced to 1 , right?

First of all, why are you transferring entire event and order. By that logic, there is no requirement for transferring first 3 parameters

captain82 · 2019-09-27T12:35:58Z

Please provide GIF.

@liveHarshit Here is a gif.

iamareebjamal · 2019-09-27T14:38:41Z

app/src/main/java/org/fossasia/openevent/general/order/OrdersUnderUserFragment.kt

-                findNavController(rootView).navigate(OrdersUnderUserFragmentDirections
-                    .actionOrderUserToOrderDetails(eventID, orderIdentifier, orderId))
+            override fun onClick(eventID: Long, orderIdentifier: String, orderId: Long, event: Event, order: Order) {
+                if (order.status.equals("completed") || order.status.equals("placed")) {


Don't use equals

@iamareebjamal Then how should I check the status is pending or completed.

@liveHarshit What you have to say about this?

How do you check for equality of 2 strings in kotlin?

iamareebjamal · 2019-09-27T14:39:08Z

app/src/main/java/org/fossasia/openevent/general/order/OrdersUnderUserFragment.kt

+                    findNavController(rootView).navigate(OrdersUnderUserFragmentDirections
+                            .actionOrderUserToOrderDetails(eventID, orderIdentifier, orderId))
+                } else if (order.status.equals("cancelled")) {
+                    rootView.snackbar("Event is Cancelled")


iamareebjamal · 2019-09-27T14:39:13Z

app/src/main/java/org/fossasia/openevent/general/order/OrdersUnderUserFragment.kt

+                } else if (order.status.equals("cancelled")) {
+                    rootView.snackbar("Event is Cancelled")
+                } else if (order.status.equals("expired")) {
+                    rootView.snackbar("Event is Expired")


captain82 added 2 commits September 20, 2019 23:09

fixes fossasia#2077.Ticket does not open now when order pending and r…

cb2831e

…edirected to payment page

fix:fossasia#2077

160e1d7

captain82 changed the title ~~fixes #2077.Ticket does not open now when order pending and redirecte…~~ fix #2077.Ticket does not open now when order pending and redirecte… Sep 20, 2019

fossasia deleted a comment Sep 20, 2019

nikit19 suggested changes Sep 20, 2019

View reviewed changes

Merge branch 'development' into development

93e626e

fossasia deleted a comment Sep 26, 2019

captain82 added 2 commits September 26, 2019 21:26

fix:fossasia#2077. Add respective payment method for pending orders

fc9d163

Merge branch 'development' of https://github.com/captain82/open-event…

abd3e5e

…-attendee-android into development

fossasia deleted a comment Sep 26, 2019

fix:fossasia#2077.Add respective payment method for pending orders

07a54a1

captain82 changed the title ~~fix #2077.Ticket does not open now when order pending and redirecte…~~ fix #2077.Pending ticket redirected to payment page. Sep 26, 2019

fix:fossasia#2077.Add payment methods for pending orders.(fossasia#2077)

b51bc93

captain82 changed the title ~~fix #2077.Pending ticket redirected to payment page.~~ fix.Pending ticket redirected to payment page. Sep 26, 2019

captain82 changed the title ~~fix.Pending ticket redirected to payment page.~~ fix:Pending ticket redirected to payment page. Sep 26, 2019

auto-label bot added the fix label Sep 26, 2019

captain82 changed the title ~~fix:Pending ticket redirected to payment page.~~ fix:pending ticket redirected to payment page. Sep 26, 2019

captain82 changed the title ~~fix:pending ticket redirected to payment page.~~ fix: pending ticket redirected to payment page. Sep 27, 2019

liveHarshit reviewed Sep 27, 2019

View reviewed changes

iamareebjamal reviewed Sep 27, 2019

View reviewed changes

thatfedupguy mentioned this pull request Dec 3, 2019

Do not open tickets if the order status is not completed #2077

Closed

fix: pending ticket redirected to payment page. #2356

Are you sure you want to change the base?

fix: pending ticket redirected to payment page. #2356

Uh oh!

Conversation

captain82 commented Sep 20, 2019 • edited by liveHarshit Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nikit19 left a comment

Choose a reason for hiding this comment

Uh oh!

liveHarshit commented Sep 20, 2019 • edited by unfurl-links bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

captain82 commented Sep 24, 2019

Uh oh!

captain82 commented Sep 24, 2019 • edited by unfurl-links bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liveHarshit commented Sep 24, 2019

Uh oh!

captain82 commented Sep 26, 2019

Uh oh!

iamareebjamal commented Sep 26, 2019

Uh oh!

captain82 commented Sep 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liveHarshit left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

captain82 commented Sep 27, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

captain82 commented Sep 20, 2019 •

edited by liveHarshit

Loading

liveHarshit commented Sep 20, 2019 •

edited by unfurl-links bot

Loading

captain82 commented Sep 24, 2019 •

edited by unfurl-links bot

Loading

captain82 commented Sep 27, 2019 •

edited

Loading