Migrate to Gradle Kotlin DSL #2353
Conversation
Signed-off-by: Aditya Wasan <[email protected]>
Signed-off-by: Aditya Wasan <[email protected]>
Signed-off-by: Aditya Wasan <[email protected]>
Signed-off-by: Aditya Wasan <[email protected]>
Signed-off-by: Aditya Wasan <[email protected]>
Removed: - local.properties gradle plugin - AndroidConfig.kt - KOTLIN_VERSION property Signed-off-by: Aditya Wasan <[email protected]>
|
@liveHarshit do i need to resolve codacy issues because most of the UnsafeCast are due to the return type being Any for the functions. |
You can fix them by using smart cast and removing non-null assertions. |
|
First goal should be passing build. Second would be polishing because the current library declarations are too verbose. We only want versions for libraries which have duplicate dependencies. We also don't know if dependabot supports this format. We can't lose auto dependency update functionality |
|
@iamareebjamal dependabot currently does not support kts. The issue is opened since a year though https://github.com/dependabot/feedback/issues/172 |
|
@iamareebjamal @adityastic so should I work on kts or close this PR and check groovy dependency management ? |
|
Leave it be. We'll iterate on it when the support is added |
|
@iamareebjamal sure, I'll just update the PR so to make sure it passes all the checks. |
Signed-off-by: Aditya Wasan <[email protected]>
app/build.gradle.kts
Outdated
| //ExpandableView | ||
| implementation(Libs.expandablelayout) | ||
|
|
||
|
|
Signed-off-by: Aditya Wasan <[email protected]>
Fixes #1410
Changes: Converted gradle files to kotlin dsl syntax