-
Notifications
You must be signed in to change notification settings - Fork 234
feat: Add basic diacritic characters, European mostly (#867) #1301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add basic diacritic characters, European mostly (#867) #1301
Conversation
Reviewer's GuideThis PR enhances the DataToByteArrayConverter by populating it with basic European diacritic characters—both uppercase and lowercase—while also cleaning up the existing mapping literal for consistent formatting. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yarda - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
These are very simple characters. I tried it looks as close as possible to the original font, feel free to improve it :). I hacked very simple editor, that can help with this task :). I hope somebody could find it useful :) https://github.com/yarda/BMPFontDesigner |
I also added empty lines for better readability of the characters table and to group them. |
Please do not merge it yet. I used AI to gather list of characters needed, and it seems it forgot "ďĎťŤ" characters which are used e.g. in Czech language. I will add them and update the PR. |
55300ff
to
f82490f
Compare
Also added "ěĚďĎňŇťŤ" characters. So at least the Czech language, which I am the most interested in, seems 100% covered now. |
Some of the added characters: Screenshots
@yarda Generally all of them look good to me, all fit within the size of the badge. Some of them had to be deformed perhaps to fit in the badge ? But in general, these look good. |
8e4d0c8
to
90e29a4
Compare
I also improved the 'Å' character a bit. |
It still isn't complete character set for all European languages alphabet, but I think it is a good start. |
@yarda The CI still fails because of the code not being formatted. Just run |
The recent force push added missing CRs to the empty lines which was probably the cause of the failure. It is according to the output of the |
@yarda Just tried it myself on your branch. It only formats the file that you've changed and removes the empty lines. |
NP, I will drop the empty lines. I probably used different dart formatter :) |
90e29a4
to
0900995
Compare
It seems 2 tests failed, but I don't know why. |
Yeah, noticed that as well. However, I may not be able to assist with this, @Jhalakupadhyay might be able to help. |
However, this is good to go once the tests pass. |
Mind updating the tests as well? |
0900995
to
e645a37
Compare
I tried to fix the tests. |
Build StatusBuild successful. APKs to test: https://github.com/fossasia/badgemagic-app/actions/runs/15421999639/artifacts/3251583181. Screenshots (Android)
Screenshots (iPhone)
Screenshots (iPad)
|
e645a37
to
126689c
Compare
In the second version of the test fix I improved the test coverage. |
126689c
to
f156d31
Compare
Fixes fossasia#867 Signed-off-by: Jaroslav Škarvada <[email protected]>
f156d31
to
d52d3ee
Compare
Fixes #867
Changes
Screenshots / Recordings
NA
Checklist:
constants.dart
without hard coding any value.I am not sure how to do this :)
Summary by Sourcery
New Features: