Update to 1.4.4 with patch for nixpkgs Go version mismatch

[firecat53]

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Update to 1.4.3. I had to add a patch to allow the build to happen as Go 1.25
has not made it into the Nix package repo yet.

To be honest, I'm not a Go or a Nix developer and I'm not sure exactly why this
patch works. It still looks like Go 1.25 is downloaded and used during the build
phase. Thanks to random internet person with a similar solution!

It's up to you if you merge this or leave it until 1.25 is available in nixpkgs.

How to test?

nix build
result/bin/newt -version

[oschwartz10612]

Thanks for investigating! Looks like it would basically build on 1.24 on nix specifically? Does nix build it from source or download the binaries. Sorry I am a nix noob 😅

[firecat53]

Nix builds it from the source tree (edited to update the version_replaceme string).

I'm still experimenting...I came over to my other (almost identical) NixOS machine and pulled in this branch and it's not building again even with this patch. Sigh.

[oschwartz10612]

Hum we could roll back to 1.24 for now maybe? I dont see harm in that.

[firecat53]

Well, I got it to build again with another small fix. I'd rather you not have to change your project just for the sake of a tiny number of Nix users 😄

Give me a minute to rebase and squash these together and then it should be ok for now. I'll keep an eye out for when Go 1.25 makes it to stable and see if we can revert the patch. I thought about splitting it up from the version change so it can be reverted, but that leaves the version update by itself which would fail to build. Thoughts?

[firecat53]

Ok, I split the commits into the patch to fix the build problem and the update to 1.4.4. It's rebased on top of your recent changes, so hopfully will merge cleanly.