Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal lints #344

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Remove internal lints #344

merged 1 commit into from
Jan 8, 2025

Conversation

Pante
Copy link
Member

@Pante Pante commented Jan 8, 2025

Describe the changes
Internal lints while useful, not has no future as it depends on custom_lint, which is in maintenance mode. This is due to the Dart analyzer team announcing a new analyzer plugin system, dart-lang/sdk#53402 .

See for more information.

Supersedes and closes #311.

Checklist

  • I have read the CONTRIBUTING.md.
  • I have included the relevant unit/golden tests.
  • I have included the relevant samples.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG.md if necessary.

@Copilot Copilot bot review requested due to automatic review settings January 8, 2025 08:41

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 17 out of 33 changed files in this pull request and generated no comments.

Files not reviewed (16)
  • forui_internal_lints/.gitignore: Language not supported
  • forui_internal_lints/.metadata: Language not supported
  • forui_internal_lints/LICENSE: Language not supported
  • forui_internal_lints/analysis_options.yaml: Language not supported
  • forui_internal_lints/lib/forui_internal_lints.dart: Language not supported
  • forui_internal_lints/lib/src/always_call_super_dispose_last.dart: Language not supported
  • forui_internal_lints/lib/src/always_provide_flag_property_parameter.dart: Language not supported
  • forui_internal_lints/lib/src/avoid_record_diagnostics_properties.dart: Language not supported
  • forui_internal_lints/lib/src/prefer_specific_diagnostics_properties.dart: Language not supported
  • forui_internal_lints/lib/src/prefer_widgets_library.dart: Language not supported
  • forui_internal_lints/lib/src/prefix_public_types.dart: Language not supported
  • forui_internal_lints/lib/src/style_api.dart: Language not supported
  • forui_internal_lints/pubspec.yaml: Language not supported
  • forui_internal_lints/testbed/.gitignore: Language not supported
  • forui_internal_lints/testbed/.metadata: Language not supported
  • forui_internal_lints/testbed/analysis_options.yaml: Language not supported
@Pante Pante merged commit 837deea into main Jan 8, 2025
15 checks passed
@Pante Pante deleted the feature/remove-lints branch January 8, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable custom lints
1 participant