Skip to content

Update bindgen [WIP] #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

jseyfried
Copy link

Closes #5.

Also bump serde_derive minor version to match that of serde and to reduce Cargo.lock bloat associated with this PR.

@jseyfried jseyfried force-pushed the update-bindgen branch 5 times, most recently from 3a6dd16 to 3bcfdda Compare December 23, 2019 15:20
@jseyfried jseyfried changed the title Update bindgen. Update bindgen [WIP] Dec 24, 2019
@jethrogb jethrogb mentioned this pull request Mar 11, 2021
1 task
@jethrogb
Copy link
Member

Final PR: #152

bors bot added a commit that referenced this pull request Apr 6, 2021
152: Update bindgen r=raoulstrackx a=jethrogb

I took some time this week to make the necessary bindgen changes (rust-lang/rust-bindgen#2004 rust-lang/rust-bindgen#2006 rust-lang/rust-bindgen#2007). This PR updates the bindgen build to use that.

Breaking changes:
* unnamed types are renamed
* C-unions are now actual unions
  * [x] the field accessor functions that used to exist are easy enough to add back
* bitfields are done differently now
* some fn-ptrs are now unsafe
* some fns and fn-ptrs now take const pointers as arguments
* havege.c and timing.c are now not compiled on non-unix platforms, i.e. SGX (probably wasn't working properly anyway)

Fixes #5 #14 #61 #72 #88 #121

Co-authored-by: Jethro Beekman <[email protected]>
@jethrogb
Copy link
Member

jethrogb commented Apr 6, 2021

Fixed in #152

@jethrogb jethrogb closed this Apr 6, 2021
mcr pushed a commit to mcr/rust-mbedtls that referenced this pull request Aug 10, 2023
The reference to time::Instant under feature = socks-proxy was
incorrectly scoped, and should have been just Instant. This breaks the
doc build and any builds that use feature = socks-proxy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade bindgen
2 participants