update to bindgen 0.51.0 #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldh
force-pushed
the
upstream_bindgen
branch
from
c6534e6 to
f7f4703
Compare
|
Got rid of the |
haraldh
force-pushed
the
upstream_bindgen
branch
from
f7f4703 to
97d9bcc
Compare
This patch lets us compile mbedtls-sys with recent clang versions.
haraldh
force-pushed
the
upstream_bindgen
branch
from
97d9bcc to
1e3d0a3
Compare
|
doh.. didn't see #14 ... could have saved me a lot of time 😿 |
haraldh
changed the title
|
LGTM. @jethrogb ? |
|
@jack-fortanix @jethrogb |
Closed
Closed
|
Final PR: #152 |
bors bot
added a commit
that referenced
this pull request
Apr 6, 2021
152: Update bindgen r=raoulstrackx a=jethrogb I took some time this week to make the necessary bindgen changes (rust-lang/rust-bindgen#2004 rust-lang/rust-bindgen#2006 rust-lang/rust-bindgen#2007). This PR updates the bindgen build to use that. Breaking changes: * unnamed types are renamed * C-unions are now actual unions * [x] the field accessor functions that used to exist are easy enough to add back * bitfields are done differently now * some fn-ptrs are now unsafe * some fns and fn-ptrs now take const pointers as arguments * havege.c and timing.c are now not compiled on non-unix platforms, i.e. SGX (probably wasn't working properly anyway) Fixes #5 #14 #61 #72 #88 #121 Co-authored-by: Jethro Beekman <[email protected]>
|
Fixed in #152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch lets us compile mbedtls-sys with recent clang versions.
It still has a hack calling "sed" in it, which fixes some of the enumgenerated names, but it is a good starting point.