-
Notifications
You must be signed in to change notification settings - Fork 84
Set CMAKE_TRY_COMPILE_TARGET_TYPE=STATIC_LIBRARY
for any target in mbedtls-sys build script
#384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Pagten
merged 1 commit into
master
from
pieagt/mbedtls-sys-always-set-cmake-try-compile-target-type
Apr 22, 2025
Merged
Set CMAKE_TRY_COMPILE_TARGET_TYPE=STATIC_LIBRARY
for any target in mbedtls-sys build script
#384
Pagten
merged 1 commit into
master
from
pieagt/mbedtls-sys-always-set-cmake-try-compile-target-type
Apr 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 8333297Click to view benchmark
|
janosimas
approved these changes
Mar 31, 2025
zugzwang
approved these changes
Mar 31, 2025
Taowyoo
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v0.1.0
version of traitobject
is conflicting with latest nightly. Need to upgrade it to 0.1.1
to solve it.
Created PR to fix it: #386, please review , merge it and rebase your PR.
bcdeb93
to
7dc9b0b
Compare
Benchmark for 21a2880Click to view benchmark
|
7dc9b0b
to
166ad04
Compare
Taowyoo
approved these changes
Apr 11, 2025
…edtls-sys build script
166ad04
to
a1efcda
Compare
Taowyoo
approved these changes
Apr 11, 2025
Benchmark for 0bd5199Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the
CMAKE_TRY_COMPILE_TARGET_TYPE
cmake define was only set toSTATIC_LIBRARY
for arm targets or when theRUST_MBED_C_COMPILER_BAREMETAL
env var is set to1
, but this define should always be set like that because we're always building a static library.The incentive for making this change is that it improves compatibility with non-standard build systems such as Bazel.