Skip to content

Conversation

@logaretm
Copy link
Member

What

Our popover implementation does not explicitly close the popover until it gets closed by its default user agent behavior (e.g: clicking outside, etc...).

Now this doesn't work for components like comboboxes, because they have a couple of elements triggers the state of the popover:

  • Focusing/interacting with the input field
  • The dropdown button

Our current implementation fails the input field interaction, specifically those scenarios:

  1. Clicking the field when the popover is open will close the popover
  2. Focusing the field by other means may accidentally close the popover

This PR fixes that by using popover=manual behavior, which would put us in full control for when the popover opens/closes.

For now I have added the click outside handling, but there could be other scenarios where we want to prevent/open the popover ourselves, we will also require some minor testing to see if we broke the current behavior as well.

@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2025

🦋 Changeset detected

Latest commit: f535caf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@formwerk/core Patch
@formwerk/devtools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ComboBox open-on-focus immediately closes popover

2 participants