-
Notifications
You must be signed in to change notification settings - Fork 81
Watch multiCheckbox model value to support async options #33
Conversation
Sounds good. I don't think there's really a concern for performance where you swapped the |
Yes, I've created a demo example locally and it works as expected |
Unit tests are not established here, so I didn't create test cases |
Yeah, this library still needs some love for sure. I'll merge this and create a release. Perfect PR. Thanks. |
Watch multiCheckbox model value to support async options
Cool, thank you 👍 |
Done: |
@kentcdodds can you publish changes to |
Whoops! I forgot that my |
@kentcdodds I am afraid it will not work, there was no new release created. I still get previous version. |
Ah! :-( I didn't notice my console totally borked on me. Try again, I just pushed it :-( Sorry @m0t0r! |
No problem. It works now, thanks for support 👍 |
Hi, @kentcdodds. I've added changes to watch model value so that support async options values (related to #32 ). Please, take a look. I didn't find a better approach. For performance improvement I use
for loop
overangular.forEach
which is not the most performant solution.As a last thing I added documentation for the multiCheckbox form field. I'll add an example for this field once the PR gets merged.
Thank you