Skip to content

syncing commit from monorepo. PR: 274, Title: FIO-9670: Fixes memory leak in angular renderer where form instances stay in memory after being destroyed #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

syncing commit from monorepo. PR: 274, Title: FIO-9670: Fixes memory leak in angular renderer where form instances stay in memory after being destroyed #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions projects/angular-formio/src/FormioBaseComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export class FormioBaseComponent implements OnInit, OnChanges, OnDestroy {
setForm(form: FormioForm) {
this.form = form;
if (this.formio) {
this.formio.destroy();
this.formio.destroy(true);
}

if (this.form.title) {
Expand Down Expand Up @@ -285,24 +285,24 @@ export class FormioBaseComponent implements OnInit, OnChanges, OnDestroy {
}
}

setFormFromSrc() {
setFormFromSrc() {
// if a submission is provided, load it first to set required form revision.
if (
isEmpty(this.submission) &&
this.service &&
this.service.formio.submissionId
) {
this.service.loadSubmission().subscribe(
(submission: any) => {
if (
isEmpty(this.submission) &&
this.service &&
this.service.formio.submissionId
) {
this.service.loadSubmission().subscribe(
(submission: any) => {
this.loadForm(() => {
if (this.readOnly) {
this.formio.options.readOnly = true;
}
this.submission = this.formio.submission = submission;
if (this.readOnly) {
this.formio.options.readOnly = true;
}
this.submission = this.formio.submission = submission;
});
},
err => this.onError(err)
);
},
err => this.onError(err)
);
} else {
this.loadForm();
}
Expand All @@ -326,7 +326,7 @@ export class FormioBaseComponent implements OnInit, OnChanges, OnDestroy {

ngOnDestroy() {
if (this.formio) {
this.formio.destroy();
this.formio.destroy(true);
}
}

Expand Down
8 changes: 4 additions & 4 deletions projects/angular-formio/src/components/formbuilder/formbuilder.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ import { CustomTagsService } from '../../custom-tags.service';

/* tslint:disable */
@Component({
selector: 'form-builder',
templateUrl: './formbuilder.component.html',
styleUrls: ['../../../../../node_modules/@formio/js/dist/formio.builder.min.css'],
selector: 'form-builder',
templateUrl: './formbuilder.component.html',
styleUrls: ['../../../../../node_modules/@formio/js/dist/formio.builder.min.css'],
encapsulation: ViewEncapsulation.None
})
/* tslint:enable */
Expand Down Expand Up @@ -207,7 +207,7 @@ export class FormBuilderComponent implements OnInit, OnChanges, OnDestroy {
}

if (this.formio) {
this.formio.destroy();
this.formio.destroy(true);
}
}
}
Loading