Feat - Hide voice video button - #190
Open
crazypeace wants to merge 3 commits into
Open
Conversation
Add a new ForkSettings boolean 'hideVoiceVideoButton' (default false) that,
when enabled, hides the voice/video message record button in the compose bar.
- core/fork_settings.{h,cpp}: serialize/read/reset/getter/setter
- settings/sections/settings_fork.cpp: toggle row in Fork settings
- history/history_widget.cpp: gate in HistoryWidget::showRecordButton()
(main chat window) plus reactive refresh subscription
- history_view_compose_controls.cpp: reactive refresh subscription
(scheduled section / replies / shortcut message editor)
- langs/lang.strings: lng_settings_hide_voice_video_button key
Based on upstream forkgram/tdesktop dev (0c13bf6).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feat is to hide voice video button in message window.
Fork Settings
Effect
Whatever textarea is empty or not, the voice video button don't display.
To be honest, I know that my fork is not a perfect practice.
But I think the core code logic is done.
I already tested the win10 amd64 compile result.
You can just pick the code you need.
Or, please tell me where I need to improve, I will try my best.
But, to be honest, I just said human language to agent to develop the code.