fix(component): update c/proudctVariantSelector to show option label #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @megasmack to sign the Salesforce Inc. Contributor License Agreement. |
Author
|
I signed the Contributor License Agreement. Clicking on the link says I signed it. Does the workflow need to be re-triggered somehow? |
ironosity
approved these changes
Aug 8, 2025
sf-tejas-nadkarni
pushed a commit
to sf-tejas-nadkarni/commerce-on-lightning-components
that referenced
this pull request
Nov 3, 2025
* fix: add variants to product details * fix: add boundary checks * fix: pr review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
transformVariantOptionsmethod was returning the "apiName" because theavailableValuesfound in the attribute info is use the apiNames. Updated to use those values to find the correct label/apiName pair found in theoptionsarray. This will keep the same value, but the value displayed in the drop down will use the label.Also added some optional chain operators to
proudctVariantSelectorUtilsmethods for better error protection.