Keep this repository in a buildable condition #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an issue from last year, #204, which @probonopd and @skef primarily contributed to.
This continues on that…it switches the build from gitbook to honkit (fork of gitbook because gitbook is deprecated and no longer supported by nodeJS, or at least, I can't get it to install anymore with
npm).It also makes minor changes to CSS so that #211 looks better.
There were minor reasons why #204 wasn't closed w/a CI workflow, basically, the generated books don't exactly match old books. I copied what I could from @probonopd's branch—the other bugs honestly should just be left as is, right now, having such an old version of the book is way worse than a version with a few gray boxes on some pages.