fix(cli): window options getting leaked into subsequent buffers - #347
Open
amadeus wants to merge 1 commit into
Open
fix(cli): window options getting leaked into subsequent buffers#347amadeus wants to merge 1 commit into
amadeus wants to merge 1 commit into
Conversation
…e cli window. Fixes folke#294 Performing :edit from the sidekick window left the new buffer with the terminal styling (no number column, fixed width, etc). The styling is now buffer-local so Neovim restores your own options, and sidekick lets go of the window when another buffer takes it over.
amadeus
changed the title
amadeus
changed the title
amadeus
commented
Jul 25, 2026
| float = { | ||
| focusable = true, | ||
| relative = "editor", | ||
| style = "minimal", |
Author
There was a problem hiding this comment.
"minimal" was ultimately removed here because all the other window options already matched except for the lack of foldcolumn = 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Performing :edit from the sidekick window left the new buffer with the terminal styling (no number column, fixed width, etc). The styling is now buffer-local so Neovim restores your own options, and sidekick lets go of the window when another buffer takes it over.
One small additional change in this PR is that using 0 for width/height of the window allows the buffer to abide by neovim's normal buffer sizing logic. A comment was added to the config to document this.
AI was used to generate the code, however I reviewed it to the best of my knowledge to ensure I could understand what it was doing and how it functioned.
Related Issue(s)
Fixes #294
Screenshots
CleanShot.2026-07-25.at.14.25.27.mp4