Fix placing blocks on plants or other non-obstacles (simple fix) #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoshinm
added a commit
to satoshinm/NetCraft
that referenced
this pull request
May 8, 2017
For example, if you right-click to place a block on a plant, then instead of doing nothing, it replaces the plant. Builds over it, instead of on it. Obstacles are still built on, as before. fogleman/Craft#181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right-clicking on a non-obstacle block (such as a plant) used to do nothing. I originally suspected it was an issue in hit testing, but turns out to be an easy fix: if the hit target is not an obstacle, then create the new block on the clicked block. This matches the commonly expected behavior e.g. in Minecraft.
Before:
After right-click, without this pull request: nothing happens
After right-click, with this pull request: