Add key shortcut to toggle fullscreen/windowed mode #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, FULLSCREEN mode would use the highest resolution supported by the monitor. For example, 5120x2880 on 5K displays, however, according to [1], the NSHighResolutionCapable key is needed to do this. Since HiDPI is overkill, and complicates application packaging requirements, instead use the scaled-down resolution. Finding this is somewhat complicated, requiring creating a window and comparing vs glfwGetFramebufferSize(), detailed in [2], but getting the scaling factor is already implemented in Craft in get_scale_factor(). This function requires a window to get the scale factor of, so create it in g->window, get the scale factor, then destroy it and recreate with the smaller window size. [1] http://www.glfw.org/docs/latest/group__window.html#ga5c336fddf2cbb5b92f65f10fb6043344 [2] http://stackoverflow.com/questions/25230841/how-to-find-display-scaling-factor-on-retina-4k-displays
|
Sorry for the size of the diff, but without updating glfw, implementing fullscreen toggle would be much less straightforward (without glfwSetWindowMonitor, the way to do it is destroy and recreate the window...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows toggling fullscreen in-game using "F11". Uses glfwSetWindowMonitor() which is new in glfw 3.2.x, so this PR also includes an update to glfw from 3.1.2 to 3.2.1 (copied from https://github.com/glfw/glfw/releases/download/3.2.1/glfw-3.2.1.zip + merged in satoshinm/NetCraft@7e34bdd)