Fix warning on nil comparison #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the more efficient /regex/.match?(value) syntax that also doesn't raise any warning if id is nil.
chris1984
approved these changes
Jan 6, 2025
|
@chris1984 are you sure the change didn't cause those test failures? |
|
Blah, I did not mean to hit merge, was adding that I would start testing it with the quick responses and my browser crashed. Let me revert and test it, if it's not related we can remerge. Acked it based on the code looking fine at a first glance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the more efficient /regex/.match?(value) syntax that also doesn't raise any warning if id is nil.