[CF] improve logging and error handling #434

MSSedusch · 2020-11-19T13:13:00Z

Improvements:

add another rescue case to catch all errors and log them
add correlation id to logs to be able to map put_block, create_block and delete_block operations

add catch all to log all errors

houndci-bot · 2020-11-19T13:13:08Z

lib/fog/azurerm/requests/storage/put_blob_block.rb

          rescue Azure::Core::Http::HTTPError => ex
+            Fog::Logger.warning "Azure error #{e.inspect}, correlation id: #{correlation_id}."
            raise_azure_exception(ex, msg)
+          rescue => e


Style/RescueStandardError: Avoid rescuing without specifying an error class.

houndci-bot · 2020-11-19T13:13:08Z

lib/fog/azurerm/requests/storage/put_blob_block.rb

          my_options[:request_id] = SecureRandom.uuid
+
+          correlation_id = SecureRandom.uuid
+          if my_options[:fog_correlation_id] != nil


Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

houndci-bot · 2020-11-19T13:13:08Z

lib/fog/azurerm/requests/storage/multipart_save_block_blob.rb

+          my_options = options.clone
+
+          correlation_id = SecureRandom.uuid
+          if my_options[:fog_correlation_id] != nil


Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

houndci-bot · 2020-11-19T13:13:09Z

lib/fog/azurerm/requests/storage/delete_blob.rb

            return true if ex.message.include?('(404)')
+            Fog::Logger.warning "Azure error #{e.inspect}, correlation id: #{correlation_id}."
            raise_azure_exception(ex, msg)
+          rescue => e


Style/RescueStandardError: Avoid rescuing without specifying an error class.

houndci-bot · 2020-11-19T13:13:09Z

lib/fog/azurerm/requests/storage/delete_blob.rb

-          msg = "Deleting blob: #{blob_name} in container #{container_name}. options: #{my_options}"
+
+          correlation_id = SecureRandom.uuid
+          if my_options[:fog_correlation_id] != nil


Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

houndci-bot · 2020-11-19T13:13:09Z

lib/fog/azurerm/requests/storage/create_block_blob.rb

          rescue Azure::Core::Http::HTTPError => ex
+            Fog::Logger.warning "Azure error #{e.inspect}, correlation id: #{correlation_id}."
            raise_azure_exception(ex, msg)
+          rescue => e


Style/RescueStandardError: Avoid rescuing without specifying an error class.

houndci-bot · 2020-11-19T13:13:09Z

lib/fog/azurerm/requests/storage/create_block_blob.rb

          my_options[:request_id] = SecureRandom.uuid
+
+          correlation_id = SecureRandom.uuid
+          if my_options[:fog_correlation_id] != nil


Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

houndci-bot · 2020-11-19T13:13:10Z

lib/fog/azurerm/requests/storage/commit_blob_blocks.rb

          rescue Azure::Core::Http::HTTPError => ex
+            Fog::Logger.warning "Azure error #{e.inspect}, correlation id: #{correlation_id}."
            raise_azure_exception(ex, msg)
+          rescue => e


Style/RescueStandardError: Avoid rescuing without specifying an error class.

houndci-bot · 2020-11-19T13:13:10Z

lib/fog/azurerm/requests/storage/commit_blob_blocks.rb

-          msg = "commit_blob_blocks: Complete uploading #{blob_name} to the container #{container_name}. options: #{my_options}"
+
+          correlation_id = SecureRandom.uuid
+          if my_options[:fog_correlation_id] != nil


Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

houndci-bot · 2020-11-19T13:13:10Z

lib/fog/azurerm/requests/storage/commit_blob_blocks.rb

          my_options = options.clone
          my_options[:request_id] = SecureRandom.uuid
-          msg = "commit_blob_blocks: Complete uploading #{blob_name} to the container #{container_name}. options: #{my_options}"
+


Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2020-11-19T13:21:09Z

lib/fog/azurerm/requests/storage/put_blob_block.rb

          my_options[:request_id] = SecureRandom.uuid
+
+          correlation_id = SecureRandom.uuid
+          if !my_options[:fog_correlation_id].nil?


Style/NegatedIf: Favor unless over if for negative conditions.

houndci-bot · 2020-11-19T13:21:09Z

lib/fog/azurerm/requests/storage/delete_blob.rb

-          msg = "Deleting blob: #{blob_name} in container #{container_name}. options: #{my_options}"
+
+          correlation_id = SecureRandom.uuid
+          if !my_options[:fog_correlation_id].nil?


Style/NegatedIf: Favor unless over if for negative conditions.

houndci-bot · 2020-11-19T13:21:09Z

lib/fog/azurerm/requests/storage/create_block_blob.rb

          my_options[:request_id] = SecureRandom.uuid
+
+          correlation_id = SecureRandom.uuid
+          if !my_options[:fog_correlation_id].nil?


Style/NegatedIf: Favor unless over if for negative conditions.

houndci-bot · 2020-11-19T13:21:09Z

lib/fog/azurerm/requests/storage/commit_blob_blocks.rb

-          msg = "commit_blob_blocks: Complete uploading #{blob_name} to the container #{container_name}. options: #{my_options}"
+
+          correlation_id = SecureRandom.uuid
+          if !my_options[:fog_correlation_id].nil?


Style/NegatedIf: Favor unless over if for negative conditions.

MSSedusch added 2 commits November 19, 2020 13:43

add correlation id to logs

ba0f4e5

add catch all to log all errors

improve correlation handling

081275f

houndci-bot reviewed Nov 19, 2020

View reviewed changes

fix style issues

c6c5543

houndci-bot reviewed Nov 19, 2020

View reviewed changes

fix style

9c65715

Uh oh!

[CF] improve logging and error handling #434

Are you sure you want to change the base?

[CF] improve logging and error handling #434

Uh oh!

Conversation

MSSedusch commented Nov 19, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants