Skip to content

Commit

Permalink
make version property in kas json schema more strict
Browse files Browse the repository at this point in the history
Previously all integers and the string "0.10" were supported. We make
this more strict by limiting the schema to versions which are actually
supported (e.g. no later versions than x). This helps users that use an
IDE with schema support to learn about the latest supported schema.

Proposed-by: Konrad Weihmann <[email protected]>
Signed-off-by: Felix Moessbauer <[email protected]>
  • Loading branch information
fmoessbauer committed Nov 11, 2024
1 parent c1fbbdc commit 93c7e77
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 2 additions & 1 deletion kas/__version__.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

__version__ = '4.5'

# Please update docs/format-changelog.rst when changing the file version.
# Please update docs/format-changelog.rst, as well as schema-kas.json when
# changing the file version.
__file_version__ = 18
__compatible_file_version__ = 1
4 changes: 3 additions & 1 deletion kas/schema-kas.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@
]
},
{
"type": "integer"
"type": "integer",
"minimum": 1,
"maximum": 18
}
]
},
Expand Down

0 comments on commit 93c7e77

Please sign in to comment.