Show check results #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…expected score objects
…sing requirements
…and maintainability
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the check results system by adding info and error fields to provide more detailed feedback. It also improves virtual environment management with configurable venv retention and updates the Docker setup for better project handling.
Changes:
- Added
infoanderrorfields toCheckResultdataclass for detailed feedback from checks - Modified virtual environment behavior to support keeping existing venvs and custom naming (
.venv-pygrader) - Enhanced results reporters to support verbose mode showing info/error details
- Added extensive unit tests for previously untested modules (virtual_environment, structure_validator, requirements_check, main, grader, etc.)
- Updated Docker configuration with entrypoint script and better volume handling
Reviewed changes
Copilot reviewed 31 out of 45 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| grader/checks/abstract_check.py | Added info and error fields to CheckResult dataclass |
| grader/checks/*_check.py | Updated all checks to populate info/error fields with meaningful output |
| grader/utils/virtual_environment.py | Added parameters for keeping existing venv and custom venv naming |
| grader/grader.py | Updated to pass venv config from configuration file |
| desktop/results_reporter.py | Added verbose mode support to display info/error fields |
| tests/unit/test_*.py | Added comprehensive unit tests for multiple modules |
| grader/utils/constants.py | Changed venv name to .venv-pygrader, updated PYLINTRC path |
| config/projects_2025.json | New configuration file with venv settings |
| justfile | Reorganized test commands to use unittest discover |
| Dockerfile | Updated with entrypoint script and improved volume mounting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add detailed configuration options for virtual environments in CLAUDE.md - Improve result handling in ResultsReporter for non-scored results - Update PylintCheck to handle complex output formats - Refactor RequirementsCheck to use context manager for virtual environment setup - Adjust Grader to utilize updated virtual environment parameters
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.