-
Notifications
You must be signed in to change notification settings - Fork 39
cubrid support #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cubrid support #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments, otherwise looks good
...y-database-cubrid/src/main/java/org/flywaydb/community/database/CUBRIDDatabaseExtension.java
Outdated
Show resolved
Hide resolved
flyway-database-cubrid/src/main/java/org/flywaydb/community/database/cubrid/CUBRIDTable.java
Outdated
Show resolved
Hide resolved
flyway-database-cubrid/src/main/java/org/flywaydb/community/database/cubrid/CUBRIDParser.java
Outdated
Show resolved
Hide resolved
...database-cubrid/src/main/java/org/flywaydb/community/database/cubrid/CUBRIDDatabaseType.java
Outdated
Show resolved
Hide resolved
flyway-database-cubrid/src/main/java/org/flywaydb/community/database/cubrid/CUBRIDDatabase.java
Outdated
Show resolved
Hide resolved
...y-database-cubrid/src/main/java/org/flywaydb/community/database/cubrid/CUBRIDConnection.java
Outdated
Show resolved
Hide resolved
...y-database-cubrid/src/main/java/org/flywaydb/community/database/CUBRIDDatabaseExtension.java
Outdated
Show resolved
Hide resolved
...y-database-cubrid/src/main/java/org/flywaydb/community/database/CUBRIDDatabaseExtension.java
Outdated
Show resolved
Hide resolved
…tabase/CUBRIDDatabaseExtension.java Co-authored-by: Piers Williams <[email protected]>
…tabase/cubrid/CUBRIDTable.java Co-authored-by: Piers Williams <[email protected]>
…tabase/cubrid/CUBRIDParser.java Co-authored-by: Piers Williams <[email protected]>
…tabase/cubrid/CUBRIDDatabaseType.java Co-authored-by: Piers Williams <[email protected]>
…tabase/cubrid/CUBRIDDatabase.java Co-authored-by: Piers Williams <[email protected]>
…tabase/cubrid/CUBRIDConnection.java Co-authored-by: Piers Williams <[email protected]>
…tabase/CUBRIDDatabaseExtension.java Co-authored-by: Piers Williams <[email protected]>
…tabase/CUBRIDDatabaseExtension.java Co-authored-by: Piers Williams <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing the PR!
If there's anything I need to revise or improve further, please let me know — I'll address it right away.
I really appreciate your feedback once again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes - looking good now
Hi,
I do not have any official affiliation with CUBRID, nor do I consider myself an expert on it. While working on a production deployment that required schema migrations, I realized that Flyway did not support CUBRID. To address this, I implemented the necessary changes to enable compatibility and would like to share my contribution with the community in case it may be helpful to others.
I would greatly appreciate any feedback you may have, and I am more than happy to make any necessary improvements.
Thank you!