fix(breadcrumbs): link to the executed workflow, not the launch plan#921
Open
1fanwang wants to merge 1 commit into
Open
fix(breadcrumbs): link to the executed workflow, not the launch plan#9211fanwang wants to merge 1 commit into
1fanwang wants to merge 1 commit into
Conversation
The execution breadcrumb's self-link, name, version, and project/domain were read from spec.launchPlan (the launch plan identity) instead of closure.workflowId (the workflow that actually ran). When a launch plan's name differs from its workflow's, the breadcrumb labels and links pointed at a non-existent workflow page. Read them from closure.workflowId, relabel the crumb "Workflow Name", and fix the domain resolution that compared projectId to the domain. Signed-off-by: 1fanwang <1fannnw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
When a launch plan is named differently from its workflow, the execution breadcrumb's link to the workflow goes nowhere — it points at the launch plan's name, which isn't a workflow, so you land on an empty page.
Type
Are all requirements met?
Complete description
The breadcrumb built its link — and the name, version, and project/domain — from
spec.launchPlan, the launch plan's identity, when it should followclosure.workflowId, the workflow that actually ran. The two usually share a name, which is why this went unnoticed. I read those fields fromclosure.workflowIdinstead, relabeled the crumb "Workflow Name", and fixed a neighboringprojectId === …domaincomparison that should have beendomainId.Smoke-tested on a live console with an execution launched through a launch plan named differently from its workflow: before, the crumb links to a workflow page that doesn't exist; after, to the real one.
executionContext.test.tscovers it.Tracking Issue
NA
Follow-up issue
NA