-
Notifications
You must be signed in to change notification settings - Fork 12
[25.05] merge in fc-24.11-dev (2025-05-21) #1496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4.11-dev/2025-05-19 [24.11] Automated nixpkgs update 2025-05-19
Perform an in-place restart of network-setup.service instead of a stop+start to avoid machines losing network connectivity due to dependent units being stopped during switch-to-configuration. The change is better placed in our nixpkgs fork than in fc-nixos. PL-133570
…ation-2411 [24.11] network: move network-setup resstart to nixpkgs
isort due to a bug (PyCQA/isort#1889) is giving us different results between CLI/Github Actions and the pre-commit hook. Switching all linting and formatting to ruff gets us back to a stable situation.
includes some manual adjustments of "fmt: skip" and "fmt: on/off" directives to account for slight differences between black and ruff.
Switch formatter to ruff because isort is having stability issues.
…ions Fixes PL-133685
Our interactive tooling `fc-manage switch -s "somespecialisation"` also supports switching to a new system on a certain specialisation. The reboot detection shall only trigger for numeric release changes for these cases as well.
Necessary for properly comparing different specialisations within the same NixOS release series.
(also causes reformat)
Do not use complicated parsing in `nixos-version` but leverage the standardizes `os-release` format.
…edule-on-specialisation agent: fix accidental immediate reboots on hosts that use specialisat…
Follow up to e7312af. Moving the code to a src subdirectory broke the coverage generation. A missing `htmlcov` directory in the build broke the whole Nix build.
Let's keep an eye on whether 51d0721 needs to be backported to fc-24.11-dev as well. |
leona-ya
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually resolved the ruff formatting change conflicts.
@flyingcircusio/release-managers
Security implications