feat(share_plus): Added excludedActivityTypes support for the iOS platform. #3376

StanleyCocos · 2024-12-03T06:30:41Z

The iOS platform is missing the exclusion feature. This PR adds the platform exclusion functionality for iOS.

fix: #3377

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I titled the PR using Conventional Commits.
I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
All existing and new tests are passing.
The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
No, this is not a breaking change.

…tform.

miquelbeltran · 2024-12-03T07:07:29Z

Thanks for this contribution as well! We have to keep this one on hold because I plan to refactor the share() method parameters, as also discussed in #3307 (comment)

Your input on this topic would be appreciated as well.

StanleyCocos · 2024-12-03T07:17:25Z

@miquelbeltran
Thank you for your reply.
I understand your plan now. If needed, I can still improve this PR after your plan.

miquelbeltran · 2024-12-18T13:46:00Z

FYI, started working on the shareplus refactor, that should simplify adding this and other optional parameters: #3404

StanleyCocos · 2024-12-19T01:31:05Z

Hi, that's great! I've been studying the code in your branch. It's really well-organized and tidy. Next, I need to add the parameter excludedActivityType for this pull request (PR) to ShareParams. After that, I'll wait for you to finish merging xx into the main branch. Once that's done, I'll synchronize my changes accordingly.

thaks:fluttercommunity#3376

# Conflicts: # packages/share_plus/share_plus/ios/share_plus/Sources/share_plus/FPPSharePlusPlugin.m # packages/share_plus/share_plus/lib/share_plus.dart # packages/share_plus/share_plus/lib/src/share_plus_linux.dart # packages/share_plus/share_plus/lib/src/share_plus_web.dart # packages/share_plus/share_plus/lib/src/share_plus_windows.dart # packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart # packages/share_plus/share_plus_platform_interface/lib/platform_interface/share_plus_platform.dart # packages/share_plus/share_plus_platform_interface/test/share_plus_platform_interface_test.dart

StanleyCocos · 2025-04-21T06:00:09Z

@miquelbeltran
I’ve updated my request based on #3404. If you have time, please take a look. Thank you.

miquelbeltran · 2025-04-21T14:36:02Z

Thanks! I haven't looked too deep into it yet, but can you describe how it works in this PR, so I can understand the change better.

And as well, add a bit of documentation about this feature on the README.md so users are aware of it.

StanleyCocos · 2025-04-22T03:45:56Z

Let me briefly describe the changes in this PR:

In share_plus_platform_interface, I declared a CupertinoActivityType enum and added it as a parameter to ShareParams. Before passing it to the iOS layer, it is transmitted as a string to make it easier for users to exclude unwanted share options on iOS and macOS.
On the iOS native side, the string passed from the Flutter layer is received and converted back into an enum, which is then applied to the share configuration.
In the example, I added a multi-selection page for easier testing. Due to structural issues, I also introduced a new MyApp class that returns a MaterialApp (this caused a number of structural and formatting changes).

miquelbeltran

Just some comments, I like the overall idea. I will also have to test this somehow.

miquelbeltran · 2025-05-01T12:34:02Z

packages/share_plus/share_plus_platform_interface/test/share_plus_platform_interface_test.dart

+            files: [XFile(fd.path)],
+            subject: 'some subject to share',
+            text: 'some text to share',
+            sharePositionOrigin: const Rect.fromLTWH(1.0, 2.0, 3.0, 4.0),
+            excludedActivityType: null),


Trailing comma missing after null

Thank you, it’s been updated.

miquelbeltran · 2025-05-01T12:34:32Z

packages/share_plus/share_plus/README.md

+you can set the excludedActivityTypes array.
+For the list of supported excludedActivityTypes, you can refer to Apple’s [documentation](https://developer.apple.com/documentation/uikit/uiactivityviewcontroller/excludedactivitytypes/).


Suggested change

you can set the excludedActivityTypes array.

For the list of supported excludedActivityTypes, you can refer to Apple’s [documentation](https://developer.apple.com/documentation/uikit/uiactivityviewcontroller/excludedactivitytypes/).

you can set the `excludedActivityTypes` array.

For the list of supported `excludedActivityTypes`, you can refer to Apple's [documentation](https://developer.apple.com/documentation/uikit/uiactivityviewcontroller/excludedactivitytypes/).

Small formatting suggestion

Shouldn't devs check the CupertinoActivityType enum instead of the Apple docs?

You’re right, it should be based on CupertinoActivityType first.

miquelbeltran · 2025-05-01T12:38:29Z

...ges/share_plus/share_plus_platform_interface/lib/platform_interface/share_plus_platform.dart

+  ///
+  /// * Supported platforms: iOS, macOS
+  ///   Parameter ignored on other platforms.
+  final List<CupertinoActivityType>? excludedActivityType;


Since it's an apple exclusive param, can we name it so it references that? e.g. excludedCupertinoActivities since the type is CupertinoActivityType.

Your suggestion is excellent — the naming alone makes the purpose clear to developers.

miquelbeltran · 2025-05-01T12:39:17Z

packages/share_plus/share_plus_platform_interface/test/share_plus_platform_interface_test.dart

-      ),
+          uri: Uri.parse('https://pub.dev/packages/share_plus'),
+          sharePositionOrigin: const Rect.fromLTWH(1.0, 2.0, 3.0, 4.0),
+          excludedActivityType: [CupertinoActivityType.airDrop]),


Missing trailing comma

Thank you, it’s been updated.

StanleyCocos · 2025-06-17T09:12:24Z

@miquelbeltran
Sorry to bother you. I noticed this request has been pending for quite a while. Do you have any plans to complete the code review soon?

miquelbeltran · 2025-06-17T09:46:36Z

...ges/share_plus/share_plus_platform_interface/lib/platform_interface/share_plus_platform.dart

+extension CupertinoActivityTypeValue on CupertinoActivityType {
+  String get value => toString().split('.').last;
+}


What is this extension used for? I don't see it used in the PR

It’s used at line 73 in method_channel_share. But I think turning it into a separate method might be a better approach now.

miquelbeltran · 2025-06-17T09:47:55Z

...ges/share_plus/share_plus_platform_interface/lib/platform_interface/share_plus_platform.dart

+/// An abstract class that you subclass to implement app-specific services
+/// for iOS and macOS.
+///
+/// https://developer.apple.com/documentation/uikit/uiactivity/activitytype


This comment doesn't seem correct to me, as these are enum values not abstract classes. Can this be reworded differently?

You’re right — I may have overlooked updating the documentation here. It’s now been revised; could you please take another look?

miquelbeltran · 2025-06-17T09:52:44Z

packages/share_plus/share_plus/ios/share_plus/Sources/share_plus/FPPSharePlusPlugin.m

+  if (excludedActivityType.count > 0) {
+    NSMutableArray *excludedActivityTypes = [[NSMutableArray alloc] init];
+    for (NSString *type in excludedActivityType) {
+      UIActivityType activityType = activityTypeForString(type);
+      if (activityType != nil) {
+        [excludedActivityTypes addObject:activityType];
+      }
+    }
+    activityViewController.excludedActivityTypes = excludedActivityTypes;
+  }


The variable names are a bit confusing here. excludedActivityType is the input parameter, which is an array (so it shouldn't be singular but plural), and I guess it contains the activity types as strings?

Then excludedActivityTypes is the actual array with activity type "types".

I'd suggest refactoring this a bit. Maybe extract the conversion of array of Strings to array of Activity Types into a function.

And then move it up on the logic, e.g. right after NSArray *excludedActivityType = arguments[@"excludedActivityType"]; in line 310. So all further calls to the share methods, e.g. self shareUri already pass an array of activity types and not an array of Strings.

Thank you for your suggestion — I’ve made the adjustments. Much appreciated!

…move the extension, and add a new get value method.

miquelbeltran

Requesting one more change, and I think this would be completed. Thanks for keeping up with the PR!

miquelbeltran · 2025-06-23T13:34:45Z

packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart

+    if (params.excludedCupertinoActivities != null &&
+        params.excludedCupertinoActivities!.isNotEmpty) {
+      final activityTypes =
+          params.excludedCupertinoActivities!.map((e) => e.value).toList();
+      map['excludedActivityType'] = activityTypes;
+    }
+


Sorry, I'll have to request another change. We renamed the variable excludedCupertinoActivities as it previously was excludedActivityType. However, I think it would be good if the map key would also be the same, to avoid confusion with that. I missed that when I first reviewed.

Thank you for your suggestion.

Slightly adjusted, but I still have some other thoughts.

I have a slightly different idea about this part. I think using excludedCupertinoActivities as the key name in the map may not be entirely appropriate, because accessing a key with “Cupertino” in its name on the iOS side feels a bit odd.

Also, I think if Android were to support a similar feature, we should still use this same key name to pass it down (even though Android doesn’t support it directly, it can potentially be handled by excluding package names).
If we do implement it for Android, I think we could introduce a new List parameter for excluded package names.

Hi! I don't see why would it feel weird to access a map value with the key Cupertino in it, as it is just the parsing of the parameters map, once read the value the variables don't need to be explicitly Cupertino.

I think if Android were to support a similar feature, we should still use this same key name to pass it down

I would disagree with that, I think keeping the params keys separated and explicit per platform (e.g. the Android one would be excludedAndroidPackages) will avoid confusion for devs not familiar with the codebase.

From the public API perspective, we should allow users to call to share() with both the Cupertino and the Android params in it, and internally it's simpler if we don't have a switch-case per platform but rather just copy each param into the corresponding params map.

Alright, it’s just a minor naming style issue. I’ve already made the adjustment.
Thank you

miquelbeltran · 2025-06-23T13:48:28Z

Tested on iOS 18.5 simulator using the example app ✅

miquelbeltran · 2025-06-24T08:48:53Z

Thanks for the changes, I think it's good to go now!

feat(share_plus): Added excludedActivityTypes support for the iOS pla…

07398ae

…tform.

StanleyCocos added 3 commits December 3, 2024 18:17

added test parameter

64cc1fe

Merge branch 'main' into feat/add_activity_type

e3485c8

fix(share_plus): the ambiguity caused by the parameter name.

5a151b2

miquelbeltran mentioned this pull request Dec 18, 2024

[Request]: share_plus refactor #3403

Closed

ozyl added a commit to ozyl/plus_plugins that referenced this pull request Feb 27, 2025

iOS support excludedActivityTypes

73186a2

thaks:fluttercommunity#3376

StanleyCocos added 7 commits April 21, 2025 09:45

add example

67bc12c

fix dart format

7a3b5fb

fix oc format

80ff165

++

871c742

fix test

e9277f9

fix: format

3c739bd

miquelbeltran self-assigned this Apr 21, 2025

update readme.md

54ea30c

miquelbeltran reviewed May 1, 2025

View reviewed changes

miquelbeltran added PR: needs review PR: needs manual testing labels May 1, 2025

++

80dea49

StanleyCocos requested a review from miquelbeltran May 6, 2025 02:04

++

f7e4025

miquelbeltran reviewed Jun 17, 2025

View reviewed changes

StanleyCocos added 4 commits June 18, 2025 09:23

feat: Adjust the documentation comments for CupertinoActivityType, re…

1bd95c7

…move the extension, and add a new get value method.

Merge branch 'main' into feat/add_activity_type

e1279c4

fix: rename parameters and refactor the conversion method.

286c326

fix: format

78d862d

StanleyCocos requested a review from miquelbeltran June 18, 2025 02:15

fix: delete CupertinoActivityTypeValue

e167f6b

miquelbeltran requested changes Jun 23, 2025

View reviewed changes

miquelbeltran removed PR: needs review PR: needs manual testing labels Jun 23, 2025

StanleyCocos added 2 commits June 24, 2025 09:19

feat: rename parameter

1076e54

fix: test

ea3ff51

StanleyCocos requested a review from miquelbeltran June 24, 2025 01:39

++

d8ccc88

miquelbeltran approved these changes Jun 24, 2025

View reviewed changes

miquelbeltran merged commit f9fdadb into fluttercommunity:main Jun 24, 2025
21 of 23 checks passed

StanleyCocos deleted the feat/add_activity_type branch June 26, 2025 01:36

		you can set the excludedActivityTypes array.
		For the list of supported excludedActivityTypes, you can refer to Apple’s [documentation](https://developer.apple.com/documentation/uikit/uiactivityviewcontroller/excludedactivitytypes/).

Uh oh!

feat(share_plus): Added excludedActivityTypes support for the iOS platform. #3376

feat(share_plus): Added excludedActivityTypes support for the iOS platform. #3376

Uh oh!

Conversation

StanleyCocos commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Breaking Change

Uh oh!

miquelbeltran commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StanleyCocos commented Dec 3, 2024

Uh oh!

miquelbeltran commented Dec 18, 2024

Uh oh!

StanleyCocos commented Dec 19, 2024

Uh oh!

StanleyCocos commented Apr 21, 2025

Uh oh!

miquelbeltran commented Apr 21, 2025

Uh oh!

StanleyCocos commented Apr 22, 2025

Uh oh!

miquelbeltran left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StanleyCocos commented Jun 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miquelbeltran left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miquelbeltran commented Jun 23, 2025

Uh oh!

miquelbeltran commented Jun 24, 2025

Uh oh!

Uh oh!

Uh oh!

StanleyCocos commented Dec 3, 2024 •

edited

Loading

miquelbeltran commented Dec 3, 2024 •

edited

Loading