Skip to content

Convert project imports to relative imports#62

Open
gupta-shrinath wants to merge 2 commits intofluttercommunity:masterfrom
gupta-shrinath:master
Open

Convert project imports to relative imports#62
gupta-shrinath wants to merge 2 commits intofluttercommunity:masterfrom
gupta-shrinath:master

Conversation

@gupta-shrinath
Copy link
Copy Markdown

@gupta-shrinath gupta-shrinath commented Oct 31, 2021

Closes #59

  • Add conversion of project imports to relative imports for lib files.
  • Add test for convertToRelativeImports

Question:
The example app has the following import but no corresponding dependency
import 'package:flutter_gen/gen_l10n/translations.dart';

@gleich
Copy link
Copy Markdown
Member

gleich commented Dec 7, 2021

Hello @gupta-shrinath. Thank you so much for sending in this PR but I am sadly archiving import_sorter (see #63). This means that your work will not be merged into import_sorter. Thank you so much for the effort in trying to improve the project.

@gleich gleich closed this Dec 7, 2021
@gleich gleich reopened this Dec 7, 2021
@vkammerer
Copy link
Copy Markdown

While I think this feature is useful, it is in my opinion out of the scope of import_sorter.
The sole responsibility of this package should be to sort imports, not update them.

@gupta-shrinath would you instead be interested in creating a separate package for this?

I see that someone else already tried to create a solution for this:

@gupta-shrinath
Copy link
Copy Markdown
Author

Thank you @gleich for the package and I understand your situation and I agree with making someone the maintainer as it is a good decision in spirit of open source.
Hey @vkammerer thank you for appreciating efforts. I think this feature could be added to this package as the code is heavily dependent on existing code. Regarding making a new package for this feature I think is not worth because as you said there is already a package / tool available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add option for relative import

3 participants