-
Notifications
You must be signed in to change notification settings - Fork 3.4k
docs: note scrollbar differences between Material and Cupertino #12899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @BenjChristiansen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Flutter documentation by clarifying how scrollbars behave differently across Material and Cupertino design systems. The update aims to provide developers with a better understanding of platform-specific UI conventions, ensuring a more native look and feel when adapting applications, and addresses a specific request from the Flutter website issue tracker. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new section to the platform adaptations documentation, explaining the differences in scrollbar behavior between Material and Cupertino platforms. The added content is clear and accurate. My main feedback is to adhere to the semantic line break style guide, which is mentioned in the PR checklist, to improve the readability and maintainability of the documentation.
sfshaza2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks, @BenjChristiansen! That is certainly a finely aged issue!
|
/gcbrun |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Oh, @BenjChristiansen, can you sign the CLA? |
|
Visit the preview URL for this PR (updated for commit 5853456): https://flutter-docs-prod--pr12899-docs-scrollbar-note-nphgu2b3.web.app |
|
Thank you for the review and approval! I signed the CLA yesterday 😀 |
|
/gcbrun |
Description of what this PR is changing or adding, and why:
Adds a short note in the Scrolling section describing visual scrollbar differences
between Material and Cupertino platforms. This clarifies platform adaptation
behavior and addresses the request in #4306.
Issues fixed by this PR (if any):
Fixes #4306
PRs or commits this PR depends on (if any):
None.
Presubmit checklist
of 80 characters or fewer.