Skip to content

[url_launcher_ios] Fix test button text to work on iOS 26 #9766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Aug 6, 2025

Handle either a "Done" (iOS 18) or a "Close" (iOS 26) button:

iOS 26 simulator:
Screenshot 2025-08-13 at 3 45 02 PM

Remove validation of UI elements (ForwardButton, Share) that the plugin doesn't control.
Fixes flutter/flutter#173100

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the iOS UI tests to handle different button labels for the 'Done' button in SFSafariViewController across different iOS versions. The change correctly uses an NSPredicate to find the button. However, the review identifies two points for improvement: the changelog entry could be clearer for public consumption, and assertions for other UI elements have been removed from the test, which reduces test coverage without explanation. These should be either restored or their removal justified.

@jmagman jmagman marked this pull request as ready for review August 13, 2025 22:41
@jmagman jmagman mentioned this pull request Aug 14, 2025
XCTAssertTrue(app.buttons["Share"].exists)
XCTAssertTrue(app.buttons["OpenInSafariButton"].exists)
let doneButton = app.buttons["Done"]
XCTAssertTrue(app.buttons["OpenInSafariButton"].waitForExistence(timeout: 30.0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the CI run this test on xcode 26, or I should manually verify this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in a PR draft running Xcode 26 beta 5 #9748. I rebased that branch onto this one. It failed before, but now passes:

Testing started
Successfully ran iOS xctest for packages/url_launcher/url_launcher_ios/example

[packages/url_launcher/url_launcher_ios completed in 1m 29s]

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8706532896630430321/+/u/Run_package_tests/native_test/stdout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[url_launcher_ios] URLLauncherUITests fail on iOS 26
2 participants