[webview_flutter_platform_interface] Provide flexible API for loading local HTML files #9697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new, more flexible API for loading local HTML files by adding a LoadFileParams class and a loadFileWithParams method to PlatformWebViewController. The changes include updates to the platform interface, new tests for the added functionality, and corresponding documentation and version updates. My review focuses on improving documentation clarity and consistency. Overall, the changes are well-implemented and tested.
.../webview_flutter/webview_flutter_platform_interface/lib/src/platform_webview_controller.dart
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_platform_interface/lib/src/types/load_file_params.dart
Outdated
Show resolved
Hide resolved
11 tasks
agavrilko
force-pushed
the
feature/#136479_webview_flutter_platform_interface
branch
from
1d4903e to
59be663
Compare
bparrishMines
approved these changes
Jul 31, 2025
| /// } | ||
| /// ``` | ||
| @immutable | ||
| class LoadFileParams { |
There was a problem hiding this comment.
nit: This can be made into a base class to ensure it is extended.
Suggested change
| class LoadFileParams { | |
| base class LoadFileParams { |
There was a problem hiding this comment.
Added base modifier.
flutter/flutter#136479 • Added LoadFileParams to specify parameters for loading local HTML pages. • PlatformWebViewController class extended with the new method loadFileWithParams(LoadFileParams).
agavrilko
force-pushed
the
feature/#136479_webview_flutter_platform_interface
branch
from
59be663 to
8adf1da
Compare
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2025
…or loading local HTML files (flutter/packages#9697)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 4, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 [email protected] Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 [email protected] Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 [email protected] [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 [email protected] Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
agavrilko
deleted the
feature/#136479_webview_flutter_platform_interface
branch
danilozhang
pushed a commit
to danilozhang/flutter
that referenced
this pull request
Aug 6, 2025
…r#173215) flutter/packages@f0645d8...1a72287 2025-08-01 [email protected] Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 [email protected] Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 [email protected] [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 [email protected] Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 6, 2025
…r#173215) flutter/packages@f0645d8...1a72287 2025-08-01 [email protected] Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 [email protected] Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 [email protected] [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 [email protected] Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
…r#173215) flutter/packages@f0645d8...1a72287 2025-08-01 [email protected] Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 [email protected] Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 [email protected] [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 [email protected] Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter#136479
These are the platform interface changes, after the main PR was approved.
#8787
What was changed:
LoadFileParamsto specify parameters for loading local HTML pages.PlatformWebViewControllerclass extended with the new methodloadFileWithParams(LoadFileParams).PlatformWebViewControllerwere added.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under[^1].CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under[^1].///).