[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list #9429
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouiseHsu
approved these changes
Jun 26, 2025
jmagman
added
the
autosubmit
I wrote that one 🙂 |
jmagman
added
the
revert
|
A reason for requesting a revert of flutter/packages/9429 could |
auto-submit
bot
removed
the
revert
|
Reason for revert: This somehow passed in presubmit but failed in postsubmit: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8710980990085669745/+/u/Run_package_tests/xcode_analyze_deprecation/stdout |
jmagman
added
the
revert
Merged
11 tasks
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Jun 26, 2025
…lusion list (#9429)" (#9507) Reverts: #9429 Initiated by: jmagman Reason for reverting: This somehow passed in presubmit but failed in postsubmit: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8710980990085669745/+/u/Run_package_tests/xcode_analyze_deprecation/stdout Original PR Author: jmagman Reviewed By: {LouiseHsu} This change reverts the following previous change: StoreKit2 is now the default and flutter/flutter#116383 is closed. Let's remove it from the deprecation exclusion list to ensure we get new deprecation warnings. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
feduke-nukem
pushed a commit
to Yobari-Timeliners/golub
that referenced
this pull request
Jun 27, 2025
…lusion list (#9429)" (#9507) Reverts: flutter/packages#9429 Initiated by: jmagman Reason for reverting: This somehow passed in presubmit but failed in postsubmit: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8710980990085669745/+/u/Run_package_tests/xcode_analyze_deprecation/stdout Original PR Author: jmagman Reviewed By: {LouiseHsu} This change reverts the following previous change: StoreKit2 is now the default and flutter/flutter#116383 is closed. Let's remove it from the deprecation exclusion list to ensure we get new deprecation warnings. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StoreKit2 is now the default and flutter/flutter#116383 is closed. Let's remove it from the deprecation exclusion list to ensure we get new deprecation warnings.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3