[google_sign_in] Redesign API for current identity SDKs #9267
+1,504
−1,173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also reworks app-facing package example app for testing.
stuartmorgan-g
requested review from
LongCatIsLooong,
cbracken,
camsim99 and
ditman
as code owners
|
LGTM. Github keeps giving me an error code when I attempt to leave a review (either with a comment or approval). |
stuartmorgan-g
added
the
federated: all_changes
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
…terface (#9454) This is the platform interface portion of #9267 It intentional makes breaking changes to the platform interface package, for the reasons described in the main PR. Part of flutter/flutter#119300 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
11 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
…plementations (#9479) This is the platform implementation portion of #9267 Part of flutter/flutter#119300 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
github-actions
bot
removed
platform-android
platform-ios
platform-macos
platform-web
labels
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/9267, because - The status or check suite Linux_android android_device_tests_shard_2 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
feduke-nukem
pushed a commit
to Yobari-Timeliners/golub
that referenced
this pull request
Jun 24, 2025
…terface (#9454) This is the platform interface portion of flutter/packages#9267 It intentional makes breaking changes to the platform interface package, for the reasons described in the main PR. Part of flutter/flutter#119300 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
feduke-nukem
pushed a commit
to Yobari-Timeliners/golub
that referenced
this pull request
Jun 24, 2025
…plementations (#9479) This is the platform implementation portion of flutter/packages#9267 Part of flutter/flutter#119300 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 24, 2025
flutter/packages@02770da...d9d3191 2025-06-24 [email protected] [google_sign_in] Redesign API for current identity SDKs (flutter/packages#9267) 2025-06-24 [email protected] [go_router] Fix routing to treat URLs with different cases (e.g., `/Home` vs `/home`) as distinct routes. (flutter/packages#9426) 2025-06-23 [email protected] [google_sign_in] Redesign API for current identity SDKs - Platform Implementations (flutter/packages#9479) 2025-06-23 [email protected] Roll Flutter from 0ab008a to d733bea (16 revisions) (flutter/packages#9478) 2025-06-23 [email protected] [go_router_builder] Skip case sensitive test (flutter/packages#9444) 2025-06-23 [email protected] [google_sign_in] Redesign API for current identity SDKs - Platform Interface (flutter/packages#9454) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…terface (flutter#9454) This is the platform interface portion of flutter#9267 It intentional makes breaking changes to the platform interface package, for the reasons described in the main PR. Part of flutter/flutter#119300 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…plementations (flutter#9479) This is the platform implementation portion of flutter#9267 Part of flutter/flutter#119300 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
This is a full overhaul of the `google_sign_in` API, with breaking changes for all component packages—including the platform interface. The usual model of adding the new approach while keeping the old one is not viable here, as the underlying SDKs have changed significantly since the original API was designed. Web already had some only-partially-compatible shims for this reason, and Android would have had to do something similar; see flutter/flutter#119300 and flutter/flutter#154205, and [the design doc](https://flutter.dev/go/google-sign-in-authn-authz-updates) for more background. - Fixes flutter/flutter#119300 - Fixes flutter/flutter#154205 - Fixes flutter/flutter#139406 - Fixes flutter/flutter#150365 - Fixes flutter/flutter#137727 - Fixes flutter/flutter#124206 - Fixes flutter/flutter#117794 - Fixes flutter/flutter#107532 - Fixes flutter/flutter#85439 - Fixes flutter/flutter#74308 - Fixes flutter/flutter#71607 - Fixes flutter/flutter#70427 - Fixes flutter/flutter#161890 - Fixes flutter/flutter#157639 - Fixes flutter/flutter#67308 - Fixes flutter/flutter#36673 - Fixes flutter/flutter#32441 (there may be more to do here over time, since we may find exceptions that are not caught, but we now have a structured system to convert errors to as we find specific unhandled cases) ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a full overhaul of the
google_sign_inAPI, with breaking changes for all component packages—including the platform interface. The usual model of adding the new approach while keeping the old one is not viable here, as the underlying SDKs have changed significantly since the original API was designed. Web already had some only-partially-compatible shims for this reason, and Android would have had to do something similar; see flutter/flutter#119300 and flutter/flutter#154205, and the design doc for more background.google_sign_into reflect changes in underlying SDKs flutter#119300play-services-authflutter#150365signInmethod. flutter#137727canAccessScopeson mobile flutter#124206onCurrentUserChangedStreamflutter#161890Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3