Skip to content

[dependabot]: Bump com.google.android.gms:play-services-maps from 18.2.0 to 19.2.0 in /packages/google_maps_flutter/google_maps_flutter_android/android #9120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 2.17.0

* Updates `com.google.android.gms:play-services-maps` to 19.2.0.
* Marks `AndroidMapRenderer.legacy` as deprecated, since it's deprecated in the
current version of the Google Maps SDK.

## 2.16.2

* Removes documentation related to the map renderer selection API, as the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ android {

dependencies {
implementation "androidx.annotation:annotation:1.9.1"
implementation 'com.google.android.gms:play-services-maps:18.2.0'
implementation 'com.google.android.gms:play-services-maps:19.2.0'
implementation 'com.google.maps.android:android-maps-utils:3.6.0'
androidTestImplementation 'androidx.test:runner:1.6.2'
androidTestImplementation 'androidx.test:rules:1.6.1'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,14 @@ static int toMapType(@NonNull Messages.PlatformMapType type) {
return MAP_TYPE_NORMAL;
}

// For now, suppress the deprecation warning for LEGACY; in theory using it
// no longer does anything, but since that's a server-side decision that could
// potentially change. Once enough time has passed that there's no plausible
// chance of the server honoring LEGACY again, that mapping can be removed and
// it can just return null, causing anyone still using the deprecated value
// in Dart to actually request the platform default (which is what the server
// is already doing in practice currently).
@SuppressWarnings("deprecation")
static @Nullable MapsInitializer.Renderer toMapRendererType(
@Nullable Messages.PlatformRendererType type) {
if (type == null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public void initializer_OnMapsSdkInitializedWithLatestRenderer() {
verify(result, never()).error(any());
}

@SuppressWarnings("deprecation")
@Test
public void initializer_OnMapsSdkInitializedWithLegacyRenderer() {
doNothing().when(googleMapInitializer).initializeWithRendererRequest(Renderer.LEGACY);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.spy;

import com.google.android.gms.internal.maps.zzag;
import com.google.android.gms.internal.maps.zzao;
import com.google.android.gms.maps.model.Polygon;
import org.junit.Test;
import org.mockito.Mockito;
Expand All @@ -16,7 +16,7 @@ public class PolygonControllerTest {

@Test
public void controller_SetsStrokeDensity() {
final zzag z = mock(zzag.class);
final zzao z = mock(zzao.class);
final Polygon polygon = spy(new Polygon(z));

final float density = 5;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.spy;

import com.google.android.gms.internal.maps.zzaj;
import com.google.android.gms.internal.maps.zzar;
import com.google.android.gms.maps.model.Polyline;
import org.junit.Test;
import org.mockito.Mockito;
Expand All @@ -16,7 +16,7 @@ public class PolylineControllerTest {

@Test
public void controller_SetsStrokeDensity() {
final zzaj z = mock(zzaj.class);
final zzar z = mock(zzar.class);
final Polyline polyline = spy(new Polyline(z));

final float density = 5;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ enum AndroidMapRenderer {
latest,

/// Legacy renderer type.
@Deprecated('The legacy renderer is no longer supported by the Google Maps, '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changed needed. I wanted to include a link to a source from maps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'SDK, so requesting it will have no effect.')
legacy,

/// Requests the default map renderer type.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: google_maps_flutter_android
description: Android implementation of the google_maps_flutter plugin.
repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
version: 2.16.2
version: 2.17.0

environment:
sdk: ^3.6.0
Expand Down