[google_maps_flutter] Add cameraControl enable/disable & position on web #9089
Conversation
4rthurmonteiro
requested review from
cbracken,
reidbaker,
ditman and
stuartmorgan-g
as code owners
| /// See [WebCameraControlPosition] for more details. | ||
| final WebCameraControlPosition? webCameraControlPosition; | ||
|
|
||
| /// This setting controls how the API handles cameraControl button on the map. Web only. |
There was a problem hiding this comment.
Have a more descriptive comment here. Something like "Enables or disables the Camera controls."
| @@ -349,6 +351,16 @@ class GoogleMap extends StatefulWidget { | |||
| /// See [WebGestureHandling] for more details. | |||
| final WebGestureHandling? webGestureHandling; | |||
|
|
|||
| /// This setting controls how the API handles cameraControl button position on the map. Web only. | |||
| /// | |||
| /// See [WebCameraControlPosition] for more details. | |||
There was a problem hiding this comment.
The comment should describe what happens if this is null.
| @@ -2,7 +2,7 @@ name: google_maps_flutter | |||
| description: A Flutter plugin for integrating Google Maps in iOS and Android applications. | |||
| repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter | |||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22 | |||
| version: 2.12.1 | |||
| version: 2.12.2 | |||
There was a problem hiding this comment.
As indicated in the PR checklist, we follow semver, which requires changing the minor version when adding public API.
There was a problem hiding this comment.
All of the google_maps_flutter_android and google_maps_flutter_ios changes can be reverted.
| @@ -1,3 +1,7 @@ | |||
| ## 2.11.2 | |||
|
|
|||
| * Adds support to camera control button on web. | |||
There was a problem hiding this comment.
"Adds support for disabling or moving the camera control button on web."
| @@ -44,6 +46,16 @@ class MapConfiguration { | |||
| /// See [WebGestureHandling] for more details. | |||
| final WebGestureHandling? webGestureHandling; | |||
|
|
|||
| /// This setting controls how the API handles cameraControl button position on the map. Web only. | |||
| /// | |||
| /// See [WebCameraControlPosition] for more details. | |||
There was a problem hiding this comment.
Same comment here; the null behavior should be documented.
| | LB RB | | ||
| | BL BC BR | | ||
| +----------------+ | ||
| */ |
There was a problem hiding this comment.
What's the purpose of duplicating this from the link below? It's not part of the doc comment, and the plugin will never be responsible for actually implementing this behavior, so it's not clear to me who the audience for this comment is.
| @@ -4,7 +4,7 @@ repository: https://github.com/flutter/packages/tree/main/packages/google_maps_f | |||
| issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22 | |||
| # NOTE: We strongly prefer non-breaking changes, even at the expense of a | |||
| # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes | |||
| version: 2.11.1 | |||
| version: 2.11.2 | |||
There was a problem hiding this comment.
Same versioning note here.
Add support to camera control button on web.
flutter/flutter#167137
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3