Skip to content

[cupertino_ui] Remove unused parameters from constructors of generic classes. - #12457

Open
srawlins wants to merge 6 commits into
flutter:mainfrom
srawlins:unused-generic-cup
Open

[cupertino_ui] Remove unused parameters from constructors of generic classes.#12457
srawlins wants to merge 6 commits into
flutter:mainfrom
srawlins:unused-generic-cup

Conversation

@srawlins

@srawlins srawlins commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes.

This is work towards dart-lang/sdk#47839.

Pre-Review Checklist

Test exempt, as this code is covered by existing static and runtime checks.

We already don't allow unused parameters from non-generic classes. There was a
bug preventing us from reporting such parameters on generic classes.

This is work towards dart-lang/sdk#47839.
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 13, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui labels Aug 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes unused super.key and super.settings parameters from the constructors of several private classes within the cupertino_ui package, specifically in context_menu.dart, route.dart, segmented_control.dart, and sheet.dart. There are no review comments to address, and no further feedback is provided.

@Piinks Piinks added triage-design Should be looked at in design triage and removed triage-framework Should be looked at in framework triage labels Aug 17, 2026
@dkwingsmt
dkwingsmt self-requested a review August 19, 2026 18:37

@dkwingsmt dkwingsmt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the clean up!

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2026

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs the pending changelog entry.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 25, 2026
@auto-submit

auto-submit Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12457, because This PR has not met approval requirements for merging. Changes were requested by {Piinks}, please make the needed changes and resubmit this PR.
The PR author is a member of flutter-hackers and needs 0 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a member of flutter-hackers before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: cupertino_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants