[cupertino_ui] Remove unused parameters from constructors of generic classes. - #12457
[cupertino_ui] Remove unused parameters from constructors of generic classes.#12457srawlins wants to merge 6 commits into
Conversation
We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes. This is work towards dart-lang/sdk#47839.
There was a problem hiding this comment.
Code Review
This pull request removes unused super.key and super.settings parameters from the constructors of several private classes within the cupertino_ui package, specifically in context_menu.dart, route.dart, segmented_control.dart, and sheet.dart. There are no review comments to address, and no further feedback is provided.
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the clean up!
Piinks
left a comment
There was a problem hiding this comment.
This still needs the pending changelog entry.
|
autosubmit label was removed for flutter/packages/12457, because This PR has not met approval requirements for merging. Changes were requested by {Piinks}, please make the needed changes and resubmit this PR.
|
We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes.
This is work towards dart-lang/sdk#47839.
Pre-Review Checklist
[shared_preferences]///).Test exempt, as this code is covered by existing static and runtime checks.