Updated analysis_options line width from flutter/flutter by justinmc · Pull Request #11692 · flutter/packages

justinmc · 2026-05-11T20:31:42Z

It seems like we're supposed to keep analysis_options.dart in sync with the one in flutter/flutter, but we haven't done it since 2023. This PR updates it. The most disruptive change appears to be the increased page width.

I'm inspired to update this after working on #11669, which imports flutter/flutter code that is formatted according to the latest rules. Better to update the rules than to format the new code back to the old rules.

Update: This only updates the line width. Other changes will follow.

gemini-code-assist

Code Review

This pull request updates the analysis_options.yaml file to synchronize with the Flutter repository, adding a formatter configuration with a 100-character page width and enabling several new linter rules such as annotate_redeclares and strict_top_level_inference. Review feedback indicates that the # not yet tested comment on the enabled omit_obvious_local_variable_types rule is misleading and should be removed. Additionally, the reviewer noted that several documentation links were broken by the introduction of relative paths and should be restored to absolute URLs.

gemini-code-assist · 2026-05-11T20:33:28Z

-    # - omit_local_variable_types # conflicts with specify_nonobvious_local_variable_types
-    - omit_obvious_local_variable_types
+    # - omit_local_variable_types # superset of omit_obvious_local_variable_types
+    - omit_obvious_local_variable_types # not yet tested


The lint omit_obvious_local_variable_types is enabled, but it is marked with a # not yet tested comment. In this file, this specific comment is consistently used for lints that are disabled (commented out) while awaiting verification. Since this lint was already active in the previous version of the configuration and remains enabled here, the comment is misleading and should be removed.

- omit_obvious_local_variable_types

Let's fix this.

gemini-code-assist · 2026-05-11T20:33:28Z

    - prefer_contains
    # - prefer_double_quotes # opposite of prefer_single_quotes
-    # - prefer_expression_function_bodies # conflicts with https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#consider-using--for-short-functions-and-methods
+    # - prefer_expression_function_bodies # conflicts with ./docs/contributing/Style-guide-for-Flutter-repo.md#consider-using--for-short-functions-and-methods


The relative path ./docs/contributing/Style-guide-for-Flutter-repo.md is broken in the context of the flutter/packages repository, as the referenced documentation resides in the flutter/flutter repository. Please restore the absolute URL to ensure the link remains functional for contributors.

# - prefer_expression_function_bodies # conflicts with https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#consider-using--for-short-functions-and-methods

gemini-code-assist · 2026-05-11T20:33:28Z

    - prefer_initializing_formals
    - prefer_inlined_adds
-    # - prefer_int_literals # conflicts with https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#use-double-literals-for-double-constants
+    # - prefer_int_literals # conflicts with ./docs/contributing/Style-guide-for-Flutter-repo.md#use-double-literals-for-double-constants


The relative path ./docs/contributing/Style-guide-for-Flutter-repo.md is broken in this repository. This link should be restored to its absolute URL to point to the correct documentation in the flutter/flutter repository.

# - prefer_int_literals # conflicts with https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#use-double-literals-for-double-constants

stuartmorgan-g · 2026-05-12T17:24:09Z

    # - prefer_double_quotes # opposite of prefer_single_quotes
-    # - prefer_expression_function_bodies # conflicts with ./docs/contributing/Style-guide-for-Flutter-repo.md#consider-using--for-short-functions-and-methods
-    - prefer_final_fields
+    # - prefer_expression_function_bodies # conflicts with https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#consider-using--for-short-functions-and-methods    - prefer_final_fields


Why was prefer_final_fields pulled into this line and thus removed?

Typo, thanks for catching that!

stuartmorgan-g · 2026-05-12T17:25:37Z

-    # - omit_local_variable_types # conflicts with specify_nonobvious_local_variable_types
-    - omit_obvious_local_variable_types
+    # - omit_local_variable_types # superset of omit_obvious_local_variable_types
+    - omit_obvious_local_variable_types # not yet tested


Let's fix this.

stuartmorgan-g · 2026-05-12T17:26:21Z

    - type_annotate_public_apis
    - type_init_formals
    - type_literal_in_constant_pattern
+    # - unawaited_futures # too many false positives, especially with the way AnimationController works


This is on, it's just in the wrong place. It's two lines down.

stuartmorgan-g · 2026-05-12T17:28:25Z

I'm not sure what's going on here, but most of the tests never ran. If you are changing the line length, you're going to have to reformat the entire repo in this PR otherwise CI will (when it actually runs) fail.

stuartmorgan-g · 2026-06-02T18:50:05Z

-      assert(library is Null); // ignore: prefer_void_to_null, type_check_with_null, https://github.com/dart-lang/sdk/issues/47017#issuecomment-907562014
+      assert(
+        library is Null,
+      ); // ignore: prefer_void_to_null, type_check_with_null, https://github.com/dart-lang/sdk/issues/47017#issuecomment-907562014


The reformat broke this // ignore; you'll need to move it manually.

Piinks · 2026-06-02T22:48:44Z

Looks like go_router_builder/example needs formatting here.

justinmc · 2026-06-02T23:00:38Z

It looks like CI is not picking up the line length change that I added to the root analysis_options.yaml for some reason. For example

-    GoRouteData.$route(path: 'int-route/:requiredIntField', factory: $IntExtensionRoute._fromState),
-    GoRouteData.$route(path: 'num-route/:requiredNumField', factory: $NumExtensionRoute._fromState),
+    GoRouteData.$route(
+      path: 'int-route/:requiredIntField',
+      factory: $IntExtensionRoute._fromState,
+    ),
+    GoRouteData.$route(
+      path: 'num-route/:requiredNumField',
+      factory: $NumExtensionRoute._fromState,
+    ),

It's telling me to go back to a shorter line length. Maybe it's because those are generated files and they should be ignored by the formatter?

This reverts commit c420322. It looks like the root analysis_options.yaml already excludes these generated files!

This reverts commit 8cc0a71.

stuartmorgan-g · 2026-06-03T12:24:26Z

Note: Normally we would publish updates for README changes (which update-excerpts triggered), but we've skipped that for mass reformats since the code is correct either way, so there's no user-driven need to publish the changes in a timely manner.

…verage issues

stuartmorgan-g · 2026-06-03T14:42:14Z

rfw has some files that had opted out of autoformat enforcement. I wasn't going to worry about that since I think we should revisit whether we support that at all now that flutter/flutter autoformats (the context here was that Hixie didn't want the formatter enforced on rfw back when the framework still didn't autoformat), but it turns out that the package has some custom coverage checking in its package-specific tests, and it has special logic based on comment annotations that the autoformatter moves. So I'm reverting the autoformat changes in the opted-out files, and I'll file an issue (edit: flutter/flutter#187508) to eventually consider removing the opt-out support (and then changing the coverage calculation logic).

stuartmorgan-g · 2026-06-03T15:50:56Z

go_router_builder is a conflict between what the autoformatter wants, and what the generator generates; there's a unit test that runs the generation and makes sure nothing changed, so currently either that test fails or the format check files. I'm sure we hit this with the last big reformat, and I'm trying to figure out how we handled it then.

justinmc · 2026-06-03T16:05:13Z

Thank you for the help here! I'll plan to wait for what you find out for go_router_builder. If you want me to apply the diffs from the failure or anything else in the meantime let me know.

stuartmorgan-g · 2026-06-03T16:21:13Z

It turns out this case was different from the previous case, but chunhtai pointed me to the actual problem and solution. For posterity (it's in comments in the PR diffs, but a comment here may be more discoverable for a future person searching old PRs like I was): the issue this time was that go_router_builder is using the dart_style package, and it uses code-based configuration rather than reading local analysis options. So go_router_builder makes code that uses the default of 80 columns, while we are expecting files in the repo to be formatted with 100 now.

So what was happening was:

The repo format check would fail if go_router_builder/example used 80-column format
expectBuildClean in ensure_build_test.dart would fail if go_router_builder/example used 100-column format, because all the checked-in, go_router_builder-generated files are the goldens for that test.

The simple solution chunhtai pointed out was that we can give go_router_builder/example custom analysis settings that set just that sub-project to 80 columns.

Updated analysis_options from flutter/flutter

f8fbd11

justinmc requested a review from stuartmorgan-g May 11, 2026 20:31

flutter-dashboard Bot added the CICD Run CI/CD label May 11, 2026

gemini-code-assist Bot reviewed May 11, 2026

View reviewed changes

Fixed some absolute URLs I missed.

ea315a2

github-actions Bot removed the CICD Run CI/CD label May 11, 2026

justinmc added the CICD Run CI/CD label May 11, 2026

justinmc mentioned this pull request May 12, 2026

Decoupling Material and Cupertino (with dart fixes) #11669

Open

11 tasks

stuartmorgan-g requested changes May 12, 2026

View reviewed changes

Stuart's review

baccf03

github-actions Bot removed the CICD Run CI/CD label May 12, 2026

dart format

4210b40

flutter-dashboard Bot added the CICD Run CI/CD label May 12, 2026

justinmc changed the title ~~Updated analysis_options from flutter/flutter~~ Updated analysis_options line width from flutter/flutter Jun 2, 2026

stuartmorgan-g reviewed Jun 2, 2026

View reviewed changes

Fix autoformatting mistake.

e6617ff

github-actions Bot removed the CICD Run CI/CD label Jun 2, 2026

justinmc added the CICD Run CI/CD label Jun 2, 2026

Skip generated files faling ci?

c420322

github-actions Bot removed the CICD Run CI/CD label Jun 2, 2026

justinmc added the CICD Run CI/CD label Jun 2, 2026

justinmc added 3 commits June 2, 2026 16:16

Revert "Skip generated files faling ci?"

b4d0844

This reverts commit c420322. It looks like the root analysis_options.yaml already excludes these generated files!

Revert "dart format ."

a58f21e

This reverts commit 8cc0a71.

dart format ., but unstage the generated files.

9e0a69c

github-actions Bot removed the CICD Run CI/CD label Jun 2, 2026

stuartmorgan-g added the CICD Run CI/CD label Jun 3, 2026

stuartmorgan-g added 3 commits June 3, 2026 08:18

Format with CI version of master

de73da9

Fix rewrapped ignore in rfw

bf90ae5

Update README excerpts

e1d245b

github-actions Bot removed the CICD Run CI/CD label Jun 3, 2026

Revert changes to rfw files that opted out of formatting, to avoid co…

9ad0179

…verage issues

Update expected go_router_builder build output for new formatter

eb3ee6c

stuartmorgan-g mentioned this pull request Jun 3, 2026

Sync analysis_options.yaml with flutter/flutter #11823

Open

stuartmorgan-g added 3 commits June 3, 2026 12:07

Revert all changes in go_router_builder_exmaple

6626e04

Explicitly use 80 chars in go_router_builder/example

a61d1ed

Undo excerpt changes in go_router_builder

dacfe87

Conversation

justinmc commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g May 12, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g May 12, 2026

Choose a reason for hiding this comment

Uh oh!

justinmc May 12, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g May 12, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g May 12, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented May 12, 2026

Uh oh!

stuartmorgan-g Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

justinmc Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

Piinks commented Jun 2, 2026

Uh oh!

justinmc commented Jun 2, 2026

Uh oh!

stuartmorgan-g commented Jun 3, 2026

Uh oh!

stuartmorgan-g commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g commented Jun 3, 2026

Uh oh!

justinmc commented Jun 3, 2026

Uh oh!

stuartmorgan-g commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

justinmc commented May 11, 2026 •

edited

Loading

stuartmorgan-g commented Jun 3, 2026 •

edited

Loading