[mustache_template] add example app and migrate README to excerpts#11407
Open
mozammal-hossain wants to merge 7 commits intoflutter:mainfrom
Open
[mustache_template] add example app and migrate README to excerpts#11407mozammal-hossain wants to merge 7 commits intoflutter:mainfrom
mozammal-hossain wants to merge 7 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the mustache_template package to version 2.0.4, introducing a new example package and migrating the README.md to use code excerpts. Feedback includes improving the clarity of the changelog entry and adhering to idiomatic Dart lints in the example code by removing unnecessary lint ignores.
third_party/packages/mustache_template/example/lib/readme_excerpts.dart
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a runnable
example/app formustache_templateand migrates README usage snippets to excerpt-managed code from that example. This addresses the missing example app noted in the issue and aligns the package with the repository’s code-excerpt documentation pattern.It also removes
mustache_templatefromscript/configs/temp_exclude_excerpt.yamlnow that excerpt support is in place, and includes the corresponding version/CHANGELOG updates.Fixes flutter/flutter#183936
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2