[pigeon] Support lists-and-maps of lists-and-maps#11400
Open
srawlins wants to merge 3 commits intoflutter:mainfrom
Open
[pigeon] Support lists-and-maps of lists-and-maps#11400srawlins wants to merge 3 commits intoflutter:mainfrom
srawlins wants to merge 3 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Pigeon Dart generator to support nested List and Map types by implementing a recursive casting mechanism. It adds nested collection fields such as boolListList, boolMapList, and boolListMap to the core test pigeons and introduces a new echoNonNullBoolListList method to the host integration API. The changes encompass updates to generated code across all supported platforms and the addition of integration tests. Feedback indicates that the objectVersion in the macOS Xcode project file was downgraded, which appears to be an unintentional change that should be reverted.
packages/pigeon/platform_tests/test_plugin/example/macos/Runner.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#116117
This PR is massive because of the added test data. 😬 But the source changes, in
lib/src/dart/dart_generator.dart, are pretty minimal.Please let me know if I added too many new test data, or if I need more.
The strategy is summed up in the doc comment to the
_castCallmethod:type, likeList<int>, the returned code is a simple call toList.cast:cast<int>().List<List<int>>, the returned code usesList.mapandList.cast:map((e) => (e! as List<Object?>).cast<int>()).toList().Map<int, List<int>>, the returned code usesMap.mapandMap.cast:map((k, v) => MapEntry(k! as int, (v! as List<Object?>).cast<int>())).Pre-Review Checklist
[shared_preferences]///).